Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected items foreground color on dark theme #47

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Fix selected items foreground color on dark theme #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion res/style/dark.qss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
QWidget {
color: #f5f5f5;
selection-background-color: #282828;
color: #f5f5f5; }
selection-color: #f5f5f5; }
QWidget::item::selected {
background-color: #282828;
color: #f5f5f5; }

QScrollBar::handle {
background-color: #4d4d4d; }
Expand Down
11 changes: 10 additions & 1 deletion res/style/dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ $input-secondary-background-color: #b2b2b2;
$foreground-color: #f5f5f5;
// Color of selected items etc.
$highlight-color: $secondary-background-color;
// Font color of selected items etc.
$highlight-foreground-color: $foreground-color;
// Main Spotify green color
$theme-color: #1db954;
// Color for disabled text etc.
Expand All @@ -50,8 +52,15 @@ $slider-handle-color: #ffffff;
}

QWidget {
selection-background-color: $highlight-color;
color: $foreground-color;

// Both selection[...] and &::item::selected{...} are needed for different OS
selection-background-color: $highlight-color;
selection-color: $highlight-foreground-color;
&::item::selected {
background-color: $highlight-color;
color: $highlight-foreground-color;
}
}

QScrollBar {
Expand Down