Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup jest-puppeteer for UI tests #7

Merged
merged 34 commits into from
Jul 9, 2020
Merged

Setup jest-puppeteer for UI tests #7

merged 34 commits into from
Jul 9, 2020

Conversation

Shulammite-Aso
Copy link

No description provided.

jywarren and others added 30 commits May 2, 2016 17:15
@jywarren
Update readme.markdown
9f3008c
@bevacqua
bump domador for tests
f75ec3a
@bevacqua
Provide an alternative implementation of bevacqua#27, fixing bevacqua#15
b3f2545
@bevacqua
Release 4.1.0
198f7c8
@bevacqua
fix bower
cbaa1d1
@bevacqua
Release 4.1.1
9a3e03a
@jywarren
readme fix and (reverted) upload response handler option
906b360 
followup readme fixes

revert prompt.js changes for separate branch

fixing mistakenly included file

additional change
@bevacqua
Merge pull request bevacqua#32 from jywarren/readme-fixes
83b93dd 
readme fixes
@bevacqua
bureaucracy
f2ac9c4
@bevacqua
linted
78a3f47
@bevacqua
Release 4.2.0
06edef0
@bevacqua
changelog bump
f83b4be
@bevacqua
Release 4.2.1
be1234e
@bevacqua
Merge pull request bevacqua#25 from jywarren/jywarren-readme-fixes
886bd65 
Fixed code example type in readme.markdown
@jywarren
domador v2.4.3
f9455bd
@bevacqua
Merge pull request bevacqua#41 from jywarren/domador-version-bump-tables
2f3aa35 
domador v2.4.3
@jywarren @bevacqua
initial stab at submitting image/attachment formData via bureaucracy (b…
a5fd0ee 
…evacqua#40)
@bevacqua
Release 4.2.2
6ec15d9
@jywarren @bevacqua
bureaucracy fieldKey addition, depends on bureaucracy v1.0.7 (bevacqu…
a632bad 
…a#42)

bump bureaucracy version
@bevacqua
Release 4.2.3
3695d65
@jywarren @bevacqua
proposed docs for expected image upload JSON response (bevacqua#43)
2d93211
@sayzlim @bevacqua
Install Carbon (bevacqua#56)
a836cbc
@jywarren @bevacqua
xhrOptions options param to pass to bureaucracy (bevacqua#44)
0fd97d0
@LoveAndCoding @bevacqua
Add Modes to Translatable Strings (bevacqua#58)
c1ac5f6
@jywarren @bevacqua
fixes for non-image attachments, closes bevacqua#45 (bevacqua#46)
b58efb7 
followup fix for non-image uploads
@bevacqua
Autogenerated pre-deployment commit
a184186
@bevacqua
bye bower
169b17b
@bevacqua
4.2.5
247c40b
@bevacqua
4.2.6
83fc4f2
@Shulammite-Aso
setup jest-puppeteer for testing
4d5cfee
@jywarren
Copy link
Owner

jywarren commented Jul 7, 2020

Wow, awesome! Perhaps you'd like to turn on Travis tests so we can see them get run in that environment? I think it could be relatively simple - like:

https://github.com/publiclab/webjack/blob/main/.travis.yml#L8

What do you think?

This was referenced Jul 7, 2020
Merged
Open
@Shulammite-Aso
Copy link
Author

Shulammite-Aso commented Jul 7, 2020 •
edited
Loading

Wow, awesome! Perhaps you'd like to turn on Travis tests so we can see them get run in that environment? I think it could be relatively simple - like:

https://github.com/publiclab/webjack/blob/main/.travis.yml#L8

What do you think?

Sure, will do this @jywarren
Will also be writing the tests for bold formatting. But having a little problem with reproducing formatting issues in a test though.☺
E.g, unlike in markdown mode where i can check whether the string strong text is included in text to know if it will be bold, i don't yet know exactly how to tell if the text you type in wysiwyg mode is Bold or not. I think using tagName will require a class or id attribute to get the element?
I don't know if there's some obvious way i haven't thought of.

cc:@keshav234156 @emilyashley @Shreyaa-s @NitinBhasneria

Other issues i think i can figure out with reading more about Jest and Puppeteer.

@Shulammite-Aso
Copy link
Author

@jywarren please, this repository does not already have a travis.yml file, and i thought we usually also need to add a repo to the travis website to triger builds on the repository?

@jywarren
Copy link
Owner

jywarren commented Jul 8, 2020

Ah ok, @Shulammite-Aso i'll add it now; you should then be able to add the .travis.yml file and it'll start working!

@jywarren
Copy link
Owner

jywarren commented Jul 8, 2020

Ah ok it seems if we add it here it should work... see https://travis-ci.com/github/jywarren/woofmark

https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci-using-github

Yes, the Travis github app has access to all my repos!

@jywarren
Copy link
Owner

jywarren commented Jul 8, 2020

Thank you!

@jywarren
Copy link
Owner

jywarren commented Jul 8, 2020

And note we'll be on .com and not .org -- 🎉

@Shulammite-Aso
Copy link
Author

Ah ok it seems if we add it here it should work... see https://travis-ci.com/github/jywarren/woofmark

https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci-using-github

Yes, the Travis github app has access to all my repos!

Oh, great! i guess i should then add the travis.yml file and push it.

@Shulammite-Aso
Copy link
Author

@jywarren please too, if you have any input on this #7 (comment)
and this publiclab/PublicLab.Editor#547 (comment) would appreciate!!

@Shulammite-Aso
Copy link
Author

Shulammite-Aso commented Jul 8, 2020 •
edited
Loading

Oh! just now noticed the check here publiclab/PublicLab.Editor#547 has completed. Finally!!!🎉

It should get merged i think?

@Shulammite-Aso
Copy link
Author

should add a basic test to make this pass on node -v 10 and 12 at least.

@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

So, we could drop Node 8 because jest doesn't work in Node 8 -- just remove it from the .travis.yml and this should pass!

Great work!

@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

Awesome!!!!!

@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

This is great. Would you mind opening this against bevacqua/woofmark and linking here? I'm going to merge this, great work!

@jywarren jywarren merged commit 5686b68 into jywarren:master Jul 9, 2020
@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

Ah, oh wait! Actually we should have opened this against the plots2 branch... can you open a new one and link here? Sorry about that, i should've caught it!

@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

See, most of our PRs have been against that branch: https://github.com/jywarren/woofmark/commits/plots2

Sorry about this! My bad!

@jywarren jywarren mentioned this pull request Jul 9, 2020
Closed
@jywarren
Copy link
Owner

jywarren commented Jul 9, 2020

OK, I opened #8, check it out. Sorry again about this!

@NitinBhasneria NitinBhasneria mentioned this pull request Jul 11, 2020
Merged
@Shulammite-Aso Shulammite-Aso mentioned this pull request Jul 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shulammite-Aso @jywarren @bevacqua @sayzlim @LoveAndCoding