Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for class attribute in links #547

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

Shulammite-Aso
Copy link
Collaborator

Fixes #512

linkBtn

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Shulammite-Aso
Copy link
Collaborator Author

@jywarren wondering why this check is not completed yet, is it normal?
Been this way for a week or more 🤔 with some of the other PR's too as I can see.

@cypherean
Copy link
Contributor

Try rebasing it?

@Shulammite-Aso
Copy link
Collaborator Author

Try rebasing it?

will do this now

@jywarren jywarren merged commit 8f509a4 into publiclab:main Jul 9, 2020
@jywarren
Copy link
Member

jywarren commented Jul 9, 2020

Great! 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some styled/custom HTML gets destroyed when converted to Markdown
3 participants