Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial stab at submitting image/attachment formData via bureaucracy #40

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

jywarren
Copy link
Collaborator

This is a first-draft attempt to solve #38 -- not sure if it's architecturally the right approach, but I believe it will pass a formData object from the images method all the way to the bureaucracy v1.0.6, and it will get appended to the form submission. How does this look?

@jywarren
Copy link
Collaborator Author

Hmm, I think i made a mistake, sorry hang on.

@jywarren jywarren force-pushed the upload-formData branch 2 times, most recently from a67910c to 38154f5 Compare August 16, 2016 14:25
@jywarren
Copy link
Collaborator Author

OK, fixed the especially dumb mistake -- but what's the best convention for passing a possibly undefined option? I set a default of {} but is that really necessary? Do we care if an undefined is passed over, or do we prefer to send over an empty object?

@bevacqua
Copy link
Owner

The argument should be optional so there shouldn't be a need to default to {}

@bevacqua
Copy link
Owner

@jywarren
Copy link
Collaborator Author

Great -- OK, how does that look?

@jywarren
Copy link
Collaborator Author

Hi, just checking if there's anything else I can do to prep this PR, of if you could pull it in and make a release? Thanks!

@bevacqua bevacqua merged commit a5fd0ee into bevacqua:master Aug 22, 2016
@bevacqua
Copy link
Owner

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants