Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added editor.value() method as both setter and getter #27

Closed
wants to merge 1 commit into from

Conversation

jywarren
Copy link
Collaborator

Followup on using editor.value() to get/set editor content for all three modes in this issue: #15

Manually tested; i didn't see a test suite but would be happy to add a test if there is one. Thanks!

@bevacqua
Copy link
Owner

Awesome stuff. I would rather parse the user input. As long as arguments.length === 1, use String(text) to set the value to their input. In case of HTML mode, convert the provided input into HTML by way of parseHTML. Only accepts Markdown (for a simpler API).

Needs docs update

update to parse user input for value() setting
@jywarren jywarren force-pushed the value-setter-getter branch from 76cc1a8 to b4ff0d6 Compare May 24, 2016 15:00
@jywarren
Copy link
Collaborator Author

OK, updated, I think; can you confirm that I've used o.parseHTML(text) correctly? This would still allow setting the raw HTML in html mode, but only because we haven't disallowed it. I updated the docs too.

Thanks!

@bevacqua
Copy link
Owner

See b3f2545

@bevacqua bevacqua closed this May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants