Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin BOM and jenkins version #502

Merged
merged 5 commits into from
Mar 24, 2022
Merged

Update plugin BOM and jenkins version #502

merged 5 commits into from
Mar 24, 2022

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Mar 22, 2022 •
edited
Loading

This PR refiles the BOM portion of #498 as it was reverted in #501 due to windows CI failures.

Failures generated are filename too long. See: https://github.com/jenkinsci/pipeline-model-definition-plugin/runs/5580211853

See also: #499

cc @basil

This was referenced Mar 22, 2022
Closed
Merged
@basil
Copy link
Member

basil commented Mar 22, 2022

Let's see if just updating the parent POM as in #503 (ignoring the BOM update and version bump) is sufficient to keep the tests stable and for my Java 17 work.

@car-roll
Copy link
Contributor Author

car-roll commented Mar 23, 2022 •
edited
Loading

I am currently testing on my local windows env to see if I can reproduce

edit: am able to reproduce locally

basil
basil requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed. Suggest closing this PR in favor of #503.

@car-roll
Copy link
Contributor Author

Looks like enable longpaths worked. Only did it for one test and it passed all other tests (most likely because of --global. Will need to clean this up properly. Either call it once for only windows, or just call it always.

@car-roll car-roll changed the title Update plugin parent POM and plugin BOM Update plugin BOM Mar 23, 2022
@car-roll
Copy link
Contributor Author

going to keep this PR open to see if we can resolve the BOM bump issues

@car-roll car-roll changed the title Update plugin BOM Update plugin BOM and jenkins version Mar 23, 2022
@car-roll car-roll added the dependencies Pull requests that update a dependency file label Mar 23, 2022
@jglick
Copy link
Member

jglick commented Mar 23, 2022

Also see #476, #504, #487 (override should be removed), and probably others.

@jglick
Copy link
Member

jglick commented Mar 23, 2022

Hmm, seems like #503 should have caused some of those to be automatically closed? 👀

@car-roll car-roll merged commit 94bc38a into jenkinsci:master Mar 24, 2022
@car-roll car-roll deleted the update-pom branch March 24, 2022 01:32
jglick
jglick reviewed Mar 24, 2022
View reviewed changes
...l-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/LibrariesTest.java
Comment on lines +164 to +165
// longpaths to support longer filenames for windows. Only needs to be set once.
otherRepo.git("config", "--global", "core.longpaths", "true");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be reverted now that jenkins-infra/pipeline-library#334 is merged?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@basil basil basil approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@car-roll @basil @jglick