Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update plugin parent POM and plugin BOM" #501

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Revert "Update plugin parent POM and plugin BOM" #501

merged 1 commit into from
Mar 22, 2022

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Mar 22, 2022 •
edited
Loading

This reverts commit 573bae0.
Identifying #498 as the cause of the recent windows CI failures

  • JENKINS issue(s):
    • Issue link or n/a
  • Description:
    • ...
  • Documentation changes:
    • Link to related jenkins.io PR or explanation for why doc change not needed
  • Users/aliases to notify:
    • ...

@car-roll
Copy link
Contributor Author

Confirmed that reverting this commit fixes the windows CI failures

@car-roll car-roll requested a review from a team March 22, 2022 18:51
@car-roll car-roll added the dependencies Pull requests that update a dependency file label Mar 22, 2022
@car-roll car-roll merged commit 275bee0 into jenkinsci:master Mar 22, 2022
@car-roll car-roll deleted the undo-deps branch March 22, 2022 22:33
@basil
Copy link
Member

basil commented Mar 22, 2022

@car-roll Why was the whole PR reverted? Rather I think only the part that caused the Windows CI failures should have been reverted.

This was referenced Mar 22, 2022
Merged
Merged
@basil
Copy link
Member

basil commented Mar 23, 2022

@car-roll Should have instead only reverted the problematic portions of #498 as was done in #503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtnord jtnord jtnord approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@car-roll @basil @jtnord