Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin parent POM and plugin BOM #498

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Mar 17, 2022

Updates the plugin parent POM from a weekly to an LTS, along with updating the plugin BOM accordingly. This is necessary in order to be able to test this plugin on Java 17, as I am trying to do in jenkinsci/bom#935. The CodeNarc Maven plugin doesn't seem to work at all on Java 17, but it appears to be adding little value so I just removed it. With these changes I can run mvn clean verify -Dtest=org.jenkinsci.plugins.pipeline.modeldefinition.DeclarativePipelineTest -DfailIfNoTests=false -Djenkins-test-harness.version=1721.v385389722736 '-DargLine=--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.util.concurrent=ALL-UNNAMED' successfully on Java 17. CC @car-roll

@olamy
Copy link
Member

olamy commented Mar 17, 2022

windows failure are not related to the change (we should that fix but later)

remote: Total 6 (delta 1), reused 0 (delta 0), pack-reused 0        
error: unable to write file .git/objects/61/392ad7ea76f42f304663ab3d819624b404bdf2: Filename too long

@car-roll
Copy link
Contributor

@olamy it does appear the failures are related to the change. See #501
I reverted this PR (#501 ) and filed #502 so that the issue can be further investigated

@olamy
Copy link
Member

olamy commented Mar 22, 2022

@olamy it does appear the failures are related to the change. See #501 I reverted this PR (#501 ) and filed #502 so that the issue can be further investigated

sounds good.
ok as I don't have any windows env for testing, I thought there were some issues on windows only due to checkout of too long paths in Jenkins but maybe something different.
Thanks to investigate

@car-roll car-roll added dependencies Pull requests that update a dependency file and removed maintenance labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants