Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize Windows build #499

Closed
wants to merge 2 commits into from
Closed

Stabilize Windows build #499

wants to merge 2 commits into from

Conversation

basil
Copy link
Member

@basil basil commented Mar 17, 2022

The Windows build appears to have become destabilized recently. This PR attempts to stabilize the build by skipping the failing tests on Windows.

@basil
Copy link
Member Author

basil commented Mar 17, 2022

CC @car-roll

@basil
Copy link
Member Author

basil commented Mar 20, 2022

The incremental build from this PR has been successfully tested with Java 17 in the draft PR jenkinsci/bom#935. In order to help facilitate the transition of that draft PR into non-draft status, it would be helpful for this PR to be merged and released.

@car-roll
Copy link
Contributor

car-roll commented Mar 22, 2022

Looks like #498 was merged a bit prematurely. But what kind of dependency update would have caused these git filename too long errors?

edit: I just checked the bom versions and it looks like git-plugin has stayed at 4.10.3.

@basil
Copy link
Member Author

basil commented Mar 22, 2022

Not sure offhand.

@basil
Copy link
Member Author

basil commented Mar 22, 2022

But what kind of dependency update would have caused these git filename too long errors?

@car-roll So rather than answering this question, you reverted the whole PR, setting back my Java 17 efforts?

@car-roll
Copy link
Contributor

@basil No, the problem was that #498 should never have been merged without those issues being resolved in the first place. I went ahead and refiled #502 so we can continue to diagnose the problem. My concern was that then any additional PRs that would have been merged to declarative that were considered "significant" would then trigger a release via automated CD and then would have caused downstream failures in PCT.

@basil
Copy link
Member Author

basil commented Mar 23, 2022

Closing in favor of #503.

@basil basil closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants