Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JEP-233] Upgrade Guava from 11.0.1 to latest #5707

Merged
merged 1 commit into from
Oct 29, 2021
Merged

[JEP-233] Upgrade Guava from 11.0.1 to latest #5707

merged 1 commit into from
Oct 29, 2021

Conversation

basil
Copy link
Member

@basil basil commented Sep 4, 2021 •
edited
Loading

Guava Library Upgraded

Proposed changelog entries

  • Jenkins has upgraded the Guava library from 11.0.1 (released on January 9, 2012) to 31.0.1 (released on September 27, 2021). Plugins have already been prepared to support the new version of Guava; use the Plugin Manager to upgrade all plugins before and after upgrading Jenkins.

Proposed upgrade guidelines

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@jenkinsci/core

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 4, 2021
@basil basil mentioned this pull request Sep 5, 2021
Merged
@jglick jglick mentioned this pull request Sep 27, 2021
Merged
@basil basil changed the title Upgrade Guava from 11.0.1 to latest [JEP-233] Upgrade Guava from 11.0.1 to latest Oct 26, 2021
@basil basil added the upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Oct 26, 2021
@basil basil marked this pull request as ready for review October 26, 2021 19:02
@basil basil requested a review from a team October 26, 2021 19:04
@timja timja requested a review from a team October 26, 2021 20:16
jglick
jglick reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW do you plan to tackle

jenkins/.github/dependabot.yml

Lines 27 to 28 in bc827ae

# needs guava upgrades first https://github.com/jenkinsci/jenkins/pull/5200#pullrequestreview-579741619
- dependency-name: "com.google.inject:guice"

jenkins/bom/pom.xml

Line 99 in bc827ae

<version>4.0</version>
next, since IIUC Guava was a prerequisite?

@basil
Copy link
Member Author

basil commented Oct 26, 2021

I already have a change for the Guice upgrade ready to be filed, but I want to get this PR shipped first to make any potential future bisection easier.

@timja
Copy link
Member

timja commented Oct 26, 2021

I already have a change for the Guice upgrade ready to be filed, but I want to get this PR shipped first to make any potential future bisection easier.

nice, I've tested a guice upgrade on top of this a month or so back, didn't hit any issues other than needing to add a couple more methods to some interface somewhere

@jglick jglick mentioned this pull request Oct 26, 2021
Merged
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 27, 2021
@timja
Copy link
Member

timja commented Oct 27, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 49cb0bd into jenkinsci:master Oct 29, 2021
@timja timja added the major-rfe For changelog: Major enhancement. Will be highlighted on the top label Oct 29, 2021
@basil basil deleted the guava branch October 29, 2021 17:30
@basil basil mentioned this pull request Oct 29, 2021
Merged
@MarkEWaite MarkEWaite mentioned this pull request Oct 29, 2021
Merged
zbynek pushed a commit to zbynek/jenkins that referenced this pull request Nov 4, 2021
@basil @zbynek
[JEP-233] Upgrade Guava from 11.0.1 to latest (jenkinsci#5707)
14d657f
@jglick
Copy link
Member

jglick commented Nov 8, 2021

@basil can we delete https://github.com/jenkinsci/plugin-pom/blob/655257b6dc9a14b44e096ed5af8d142711068069/pom.xml#L541 now or at some point?

jglick added a commit to jglick/artifact-manager-s3-plugin that referenced this pull request Nov 9, 2021
@jglick
jenkinsci/jenkins#5707 released
e1cfc30
@basil basil mentioned this pull request Nov 10, 2021
Merged
10 tasks
batmat added a commit to batmat/saml-plugin that referenced this pull request Nov 30, 2021
@batmat
Verify the version past the Guava & Guice bumps
89ba831 
jenkinsci/jenkins#5707
jenkinsci/jenkins#5858
@batmat batmat mentioned this pull request Nov 30, 2021
Merged
2 tasks
batmat added a commit to batmat/saml-plugin that referenced this pull request Dec 1, 2021
@batmat
Verify the version past the Guava & Guice bumps
b89d873 
jenkinsci/jenkins#5707
jenkinsci/jenkins#5858
kuisathaverat added a commit to jenkinsci/saml-plugin that referenced this pull request Jan 31, 2022
@batmat @kuisathaverat
Verify the version past the Guava & Guice bumps (#140)
42be439 
* No-op change to check CI result

I suspect some unrelated problem to another change I'm trying to submit.

* Verify the version past the Guava & Guice bumps

jenkinsci/jenkins#5707
jenkinsci/jenkins#5858

* Add missing comma

* Remove JDK8 builds

Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>

Co-authored-by: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this pull request Feb 22, 2022
Merged
6 tasks
@daniel-beck daniel-beck mentioned this pull request Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@res0nance res0nance res0nance approved these changes

@timja timja timja approved these changes

@jetersen jetersen jetersen approved these changes

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code major-rfe For changelog: Major enhancement. Will be highlighted on the top ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@basil @timja @jglick @olamy @jetersen @res0nance