Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Guava's Files.copy with commons FileUtils in test #565

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

raul-arabaolaza
Copy link

@raul-arabaolaza raul-arabaolaza commented Feb 22, 2022

As there is no way to make simple code that works for both Guava 11 and 31. I could wait for 2.332.1 to be released, update the baseline and make all the needed changes in the code to the new Guava classes, but in two years I will have to do it again...

Note this is affecting only a test, no production code, so just running the test proves it works.

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

…in test

As there is no way to make simple code that works for both Guava 11 and 31

Note this is affecting only a test, no production code.
@raul-arabaolaza raul-arabaolaza changed the title Remove the usage of Guava's Files.copy in favor of commons FileUtils … Replace Guava's Files.copy with commons FileUtils in test Feb 22, 2022
@lifeofguenter
Copy link
Contributor

thanks, apologies, do you have more context why this needs to be changed? Something being deprecated soon?

@KalleOlaviNiemitalo
Copy link
Contributor

Is this related to jenkinsci/jenkins#5858 in Jenkins 2.321?

@KalleOlaviNiemitalo
Copy link
Contributor

Or rather jenkinsci/jenkins#5707 in Jenkins 2.320

@lifeofguenter lifeofguenter added the java Pull requests that update Java code label Feb 22, 2022
@lifeofguenter lifeofguenter merged commit 081ee22 into jenkinsci:master Feb 22, 2022
@raul-arabaolaza
Copy link
Author

Sorry for the delay and the short description @lifeofguenter @KalleOlaviNiemitalo I was in a bit of hurry and I wasn't expecting such quick response (thanks!).

As you have properly inferred this is about jenkinsci/jenkins#5707 note I have not found any production code affected but our pipelines (running the PCT) are broken due to this and the same can be expected by anyone trying to use -Djenkins.version when running the tests or if someday this plugin is added to https://ci.jenkins.io/blue/organizations/jenkins/Tools%2Fbom/detail/master/769/pipeline. Or the next baseline bump

@raul-arabaolaza raul-arabaolaza deleted the FIX_GUAVA_TESTS branch February 23, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants