Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JEP-233] Blog post about Guava library upgrade #4640

Merged
merged 9 commits into from
Nov 9, 2021
Merged

[JEP-233] Blog post about Guava library upgrade #4640

merged 9 commits into from
Nov 9, 2021

Conversation

basil
Copy link
Contributor

@basil basil commented Oct 17, 2021 •
edited
Loading

@basil basil requested a review from a team as a code owner October 17, 2021 21:45
MarkEWaite
MarkEWaite approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with the caveat that the TODO fields need to be updated and the file name needs to have a specific date rather than TODO.

Thanks so much for your work on the Guava upgrade!

@basil basil mentioned this pull request Oct 26, 2021
Merged
10 tasks
jglick
jglick approved these changes Oct 26, 2021
View reviewed changes
content/_data/authors/basil.adoc
twitter: bcrow
linkedin: basilcrow
---
Basil is a long-time Jenkins user and contributor, a Jenkins core maintainer, and the maintainer of the plugin:email-ext[Email Extension], plugin:timestamper[Timestamper], and plugin:swarm[Swarm] plugins (among others).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First blog post! 👋

bitwiseman
bitwiseman reviewed Oct 26, 2021
View reviewed changes
content/blog/2021/11/2021-11-TODO-guava-upgrade.adoc Outdated

If you find a regression in a plugin, please file a bug report in Jira:

* link:https://issues.jenkins.io/issues/?jql=labels%20in%20(JEP-233)%20and%20status%20not%20in%20(resolved%2C%20closed)[Open JEP-233 issues]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jira makes it hard to find but there a search term for "unresolved". Slightly cleaner than "not in (resolved, closed)".

Suggested change
* link:https://issues.jenkins.io/issues/?jql=labels%20in%20(JEP-233)%20and%20status%20not%20in%20(resolved%2C%20closed)[Open JEP-233 issues]
* link:https://issues.jenkins.io/issues/?jql=resolution%20%3D%20Unresolved%20AND%20labels%20%3D%20JEP-233[Open JEP-233 issues]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query excludes issues whose status is "Fixed but Unreleased." I want to include such issues in the query because from the user's perspective the plugin still has a compatibility problem until a release occurs.

bitwiseman
bitwiseman approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Mark, this looks good once the TODOs are filled in.

@MarkEWaite
Copy link
Contributor

Congratulations on the merge of jenkinsci/jenkins#5707 !

The Jenkins 2.319 release will not include this change because it is a security release and weekly security releases include the previous weekly (2.318) and only add the security fixes.

The first Jenkins release that will include this change is expected to be Jenkins 2.320, scheduled to release Nov 10, 2021. We should be able to post the blog that same day, or the day before.

Thanks again @basil for your dedication to bring this improvement to completion.

@basil
Copy link
Contributor Author

basil commented Nov 9, 2021

@MarkEWaite @timja Is now a good time to publish this? Let me know if there's anything else I need to do from my side.

@timja
Copy link
Member

timja commented Nov 9, 2021

@MarkEWaite @timja Is now a good time to publish this? Let me know if there's anything else I need to do from my side.

update the file name to reflect todays date :) yes now is good

@basil
Copy link
Contributor Author

basil commented Nov 9, 2021

update the file name to reflect todays date :)

Done

@timja timja enabled auto-merge (squash) November 9, 2021 17:45
@timja timja merged commit bca105e into jenkins-infra:master Nov 9, 2021
@basil basil deleted the guava branch November 9, 2021 17:56
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Nov 9, 2021 •
edited
Loading

Thanks very much @basil ! Jenkins 2.320 build is complete and all components are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@bitwiseman bitwiseman bitwiseman approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
blogpost
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@basil @MarkEWaite @timja @jglick @bitwiseman