[JENKINS-66984] Pick up newer Guava from core #244
Conversation
| </dependencies> | ||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-2.249.x</artifactId> | ||
| <artifactId>bom-2.249.x</artifactId> <!-- TODO weekly --> |
There was a problem hiding this comment.
would it not be better to use 2.303 so at least you are closed to the core and pick up any other plugins that requrie the new Guava?
There was a problem hiding this comment.
jenkinsci/bom#671 would be more appropriate for this purpose. I punted on it because #242 (comment) suggests that I would need to make a bigger patch.
| @@ -201,7 +201,7 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen | |||
| wc.getPage(b, "artifact/3/4/"); | |||
| int httpCount = httpLogging.getRecords().size(); | |||
| System.err.println("total count: " + httpCount); | |||
| assertThat(httpCount, lessThanOrEqualTo(11)); | |||
| assertThat(httpCount, lessThanOrEqualTo(13)); | |||
There was a problem hiding this comment.
why does changing the core, change this number? any clues would be helpful in an inline comment.
There was a problem hiding this comment.
Took me some bisecting, but see 19e3b48
|
|
@jglick can we get a new release on this? PCT fails on |
|
OK. It looks like jenkinsci/jenkins#5858 has been released, too, so I can try taking advantage of that next. |
JENKINS-66984
Downstream of jenkinsci/jenkins#5707.
#215 and #226 might need to wait for a Guice upgrade.
See e.g. #140 for motivation.