-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker] use the new model card utilities for saving model cards from the training script #6891
Comments
All yours! |
Hi @sayakpaul, I checked #6729 and attempted to run your test notebook (https://huggingface.co/sayakpaul/test-model-card-template-dreambooth/blob/main/test_dreambooth_model_card.ipynb). However, it appears to not work for #6729 as it uses the |
Oh, it seems not only notebooks, but also training scripts in examples are not workings now. |
Hi @sayakpaul, I would love to work on this issue. I read the #6729 and based on my understanding what we have to do is -
|
If this is the case then I would be happy to work on ControlNet and ControlNetSDXL. |
@bamps53 I have fixed the example notebook to clear the errors. So, that should be fine. Have reviewed your PR: #6895 as well. It looks solid. I have also updated the description of this issue, clearly mentioning that contributors should open one PR at a time, targeting only one example. Hope that helps. |
@Bhavay-2001 I don't think you need to add any training script. We need to make use of the utilities (as shown in my example notebook and also in the PR) to create the model cards of the examples I have listed in the description. Is it more clear? |
@sayakpaul |
I think you misunderstood the description. The PR should target the actual training scripts. I asked for a notebook example to be able to quickly verify if the changes lead to expected README. The notebook can be a part of the PR description but not a part of the PR changes. If you check the reference PR, this is exactly what I have done. Not sure how I can convey this more thoroughly. |
Yes, I believe I understand that. I didn't include the notebook in the PR. Just attached it to the description of each PR. |
Hello @sayakpaul, I would love to work on all the T2I ones. Thank you! |
Yes, feel free to! |
hi @sayakpaul could I claim Advanced Diffusion Training and Advanced Diffusion SDXL? |
I'll take Textual Inversion SDXL if it's available! |
@chiral-carbon, @Stepheni12 feel free to proceed :) |
Hi @sayakpaul, I have also some pending PRs from a previous issue #6585. Can you please check them as well? |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Hi sorry, I’m going to push a PR by the end of the week and was delayed due to some heavy backlog in my work, sorry about it. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Hi @sayakpaul sorry for the delay! I have opened 2 new PRs for the tasks I had picked up. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
@sayakpaul Can we close? Or should we remove the stale label? |
I think it's okay to close. |
@sayakpaul @a-r-r-o-w @linoytsaban should I close the PRs I had made? they haven't been reviewed since I had last made commits to address comments 😅 |
Oh sorry, no need to close them! I've requested reviews from Linoy - we should be able to merge them soon if we get an approved review |
With #6729, we shifted to a more resilient and robust way to generate model cards from the DreamBooth training scripts.
So, we're keen for the community to help us do this for the other training scripts that save model cards:
While creating PRs, please also supply a notebook that generates the model card for a respective example. An example is available here: #6729 (comment). Use #6729 as a reference (only refer to the changes made in the training scripts). Please also target ONLY ONE example at a time in your PRs.
Please also tag me for a review when you open the PRs.
The text was updated successfully, but these errors were encountered: