Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] use the new model card utilities for saving model cards from the training script #6891

Closed
9 of 11 tasks
sayakpaul opened this issue Feb 7, 2024 · 28 comments · Fixed by #7613 · May be fixed by #7615
Closed
9 of 11 tasks

[Tracker] use the new model card utilities for saving model cards from the training script #6891

sayakpaul opened this issue Feb 7, 2024 · 28 comments · Fixed by #7613 · May be fixed by #7615

Comments

@sayakpaul
Copy link
Member

sayakpaul commented Feb 7, 2024

With #6729, we shifted to a more resilient and robust way to generate model cards from the DreamBooth training scripts.

So, we're keen for the community to help us do this for the other training scripts that save model cards:

While creating PRs, please also supply a notebook that generates the model card for a respective example. An example is available here: #6729 (comment). Use #6729 as a reference (only refer to the changes made in the training scripts). Please also target ONLY ONE example at a time in your PRs.

Please also tag me for a review when you open the PRs.

@sayakpaul
Copy link
Member Author

All yours!

@bamps53
Copy link
Contributor

bamps53 commented Feb 7, 2024

Hi @sayakpaul, I checked #6729 and attempted to run your test notebook (https://huggingface.co/sayakpaul/test-model-card-template-dreambooth/blob/main/test_dreambooth_model_card.ipynb). However, it appears to not work for #6729 as it uses the instance_prompt keyword arguments in load_or_create_model_card. Changing it to prompt seems to fix the issue. My question is about the maintenance of these notebooks. Is it ok to create a notebook just to verify that my PR is working at the time?

@bamps53
Copy link
Contributor

bamps53 commented Feb 7, 2024

Oh, it seems not only notebooks, but also training scripts in examples are not workings now.
I made PR #6895 to fix these before this issue.

@Bhavay-2001
Copy link
Contributor

Hi @sayakpaul, I would love to work on this issue. I read the #6729 and based on my understanding what we have to do is -

  1. We need to add a training script for these models where we append the changes you mentioned in [Model Card] standardize dreambooth model card  #6729. Basically all those changes that you made to this file examples/dreambooth/train_dreambooth_lora.py
  2. We need to use your notebook and generate model_cards for different models as well right?

@Bhavay-2001
Copy link
Contributor

If this is the case then I would be happy to work on ControlNet and ControlNetSDXL.

@bamps53 bamps53 mentioned this issue Feb 7, 2024
17 tasks
@sayakpaul
Copy link
Member Author

@bamps53 I have fixed the example notebook to clear the errors. So, that should be fine. Have reviewed your PR: #6895 as well. It looks solid.

I have also updated the description of this issue, clearly mentioning that contributors should open one PR at a time, targeting only one example. Hope that helps.

@sayakpaul
Copy link
Member Author

@Bhavay-2001 I don't think you need to add any training script. We need to make use of the utilities (as shown in my example notebook and also in the PR) to create the model cards of the examples I have listed in the description. Is it more clear?

@bamps53
Copy link
Contributor

bamps53 commented Feb 8, 2024

@sayakpaul
Thanks, I got it!
I'll split the PR for each.

@bamps53
Copy link
Contributor

bamps53 commented Feb 8, 2024

Sorry for the mess, but I created 3 PRs for each controlnet training scripts!
#6908
#6909
#6910

By the way it was more tadious to create notebooks than modifying code itself... Any better way?

@sayakpaul
Copy link
Member Author

sayakpaul commented Feb 8, 2024

I think you misunderstood the description. The PR should target the actual training scripts. I asked for a notebook example to be able to quickly verify if the changes lead to expected README. The notebook can be a part of the PR description but not a part of the PR changes. If you check the reference PR, this is exactly what I have done.

Not sure how I can convey this more thoroughly.

@bamps53
Copy link
Contributor

bamps53 commented Feb 8, 2024

Yes, I believe I understand that. I didn't include the notebook in the PR. Just attached it to the description of each PR.

@cosmo3769
Copy link
Contributor

Hello @sayakpaul, I would love to work on all the T2I ones. Thank you!

@sayakpaul
Copy link
Member Author

Yes, feel free to!

@chiral-carbon
Copy link
Contributor

hi @sayakpaul could I claim Advanced Diffusion Training and Advanced Diffusion SDXL?

@stephen-iezzi
Copy link
Contributor

I'll take Textual Inversion SDXL if it's available!

@sayakpaul
Copy link
Member Author

@chiral-carbon, @Stepheni12 feel free to proceed :)

@Bhavay-2001
Copy link
Contributor

Hi @sayakpaul, I have also some pending PRs from a previous issue #6585. Can you please check them as well?

Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 12, 2024
@chiral-carbon
Copy link
Contributor

Hi sorry, I’m going to push a PR by the end of the week and was delayed due to some heavy backlog in my work, sorry about it.

@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Mar 12, 2024
Copy link

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@chiral-carbon
Copy link
Contributor

Hi @sayakpaul sorry for the delay! I have opened 2 new PRs for the tasks I had picked up.

@github-actions github-actions bot removed the stale Issues that haven't received updates label Apr 10, 2024
Copy link

github-actions bot commented May 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label May 4, 2024
@linoytsaban linoytsaban removed the stale Issues that haven't received updates label May 5, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Sep 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Oct 12, 2024
@a-r-r-o-w
Copy link
Member

@sayakpaul Can we close? Or should we remove the stale label?

@sayakpaul sayakpaul removed the stale Issues that haven't received updates label Oct 16, 2024
@sayakpaul
Copy link
Member Author

I think it's okay to close.

@chiral-carbon
Copy link
Contributor

@sayakpaul @a-r-r-o-w @linoytsaban should I close the PRs I had made? they haven't been reviewed since I had last made commits to address comments 😅

@a-r-r-o-w
Copy link
Member

Oh sorry, no need to close them! I've requested reviews from Linoy - we should be able to merge them soon if we get an approved review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants