Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update train_dreambooth_lora_sd15_advanced.py #6978

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bhavay-2001
Copy link
Contributor

@Bhavay-2001 Bhavay-2001 commented Feb 14, 2024

What does this PR do?

Part of #6891.
Notebook - here

Before submitting

Who can review?

@sayakpaul

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@linoytsaban linoytsaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bhavay-2001!
overall lgtm :), Could you share an example of the generated model card?(doesn't have to be a notebook, just an output you generated with the modified code would be great) so we can see the formatting of the pivotal tuning triggers etc.

@Bhavay-2001
Copy link
Contributor Author

Hi @linoytsaban, I will generate the notebook itself and will deploy it on HF. Thanks

@Bhavay-2001
Copy link
Contributor Author

Hi @linoytsaban, I have added the notebook. If it is correct, can you please merge this PR?
Thanks

@Bhavay-2001
Copy link
Contributor Author

Also, I couldn't get the check error. How we need to re-format the file?

@Bhavay-2001
Copy link
Contributor Author

Hi @linoytsaban, can you please review this?
Thanks

@Bhavay-2001
Copy link
Contributor Author

Hi @linoytsaban, can you please review the notebook and merge the PR? I couldn't understand the error of re-formatting the file soo can you please comment on that as well?

@Bhavay-2001
Copy link
Contributor Author

Hi @linoytsaban, can you please let me know about the changes?
Thanks

@linoytsaban
Copy link
Collaborator

Hi @Bhavay-2001! I'm sorry, I missed your changes after my comment. Will take a look at the notebook. Thanks!

Copy link

github-actions bot commented Apr 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Apr 7, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Apr 8, 2024
Copy link

github-actions bot commented May 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants