Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize model card for textual inversion sdxl #6963

Conversation

stephen-iezzi
Copy link
Contributor

@stephen-iezzi stephen-iezzi commented Feb 13, 2024

What does this PR do?

In reference to: #6891

Standardizes textual inversion sdxl model card

Notebook link here

Before submitting

Who can review?

@sayakpaul

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stephen-iezzi
Copy link
Contributor Author

This should be good to merge now @sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after the styling problems have been fixed. I have left a minor suggestion as well.

@stephen-iezzi
Copy link
Contributor Author

Ok, I cleaned that all up! I appreciate all of your input on this @sayakpaul, I mistakenly ran isort against the file and it shuffled around the formatting of all the imports. I should've just ran make style instead.

@sayakpaul
Copy link
Member

sayakpaul commented Feb 16, 2024

The code quality is still not resolved. I am afraid if that is not resolved, we cannot merge the PR.

You need to run make style && make quality. This is what I usually do:

  1. Create a new Python virtual environment.
  2. Activate the environment.
  3. Go to diffusers directory.
  4. Run pip install -e ".[quality]"
  5. Then from the root level of the diffusers directory, run make style && make quality.

@stephen-iezzi
Copy link
Contributor Author

Hmm that's odd, I copied over the imports from the current version of the file on the main branch so not sure why it was failing the tests if that is the code already on main. Either way, I ran make style and make quality and committed those changes. I'll make sure to check for these issues locally instead of creating all these unnecessary commits next time.

@sayakpaul
Copy link
Member

Nice code quality tests are passing now. Once the CI run is complete, will merge :)

@sayakpaul sayakpaul merged commit 104afbc into huggingface:main Feb 16, 2024
13 checks passed
@sayakpaul
Copy link
Member

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants