[Model Card] standardize advanced diffusion training sd15 lora #7613
Conversation
There was a problem hiding this comment.
Thanks @chiral-carbon! just a small comment about the lora/dora tag, other than that LGTM :)
| tags = ["text-to-image", | ||
| "diffusers", | ||
| "diffusers-training", | ||
| "lora", |
There was a problem hiding this comment.
since it can be either a LoRA or a DoRA, we need to check if the use_dora arg is True and adapt the tag accordingly
(we check that in the line - lora = "lora" if not use_dora else "dora" :) )
There was a problem hiding this comment.
got it, my bad for removing the check! thanks for pointing out, pushing it now.
There was a problem hiding this comment.
lets just switch "lora" in the tags here to lora and we're good to go 😊
|
cc @linoytsaban have addressed the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@linoytsaban hi! is this PR good to be merged? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@linoytsaban hello, this has been open for some time. are there any issues still with the changes? :) |
|
Thanks! |
* modelcard generation edit * add missed tag * fix param name * fix var * change str to dict * add use_dora check * use correct tags for lora * make style && make quality --------- Co-authored-by: Aryan <aryan@huggingface.co>
* modelcard generation edit * add missed tag * fix param name * fix var * change str to dict * add use_dora check * use correct tags for lora * make style && make quality --------- Co-authored-by: Aryan <aryan@huggingface.co>
What does this PR do?
Fixes #6891 for Advanced Diffusion Training with LoRA
Notebook example: Jupyter notebook
Example model card: Model Card
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @linoytsaban