[Tracker] change to posix for better Windows support

[sayakpaul]

In #6564, @fabiorigano introduced the use of Posix to better support Windows compatibility.

It'd be nice to change the instances of os.path.join() to Path(...).as_posix().

Feel free to open PRs for this and tag me.

While opening PRs, please target only ONE script at a time.

Let's go 🚀

[Bhavay-2001]

Hi @sayakpaul, I checked the mentioned PR and also understood the issue. This is a documentation change right? We need to change every instance of os.path.join() to Path(...).as_posix()?

[charchit7]

Hi @sayakpaul, I checked the mentioned PR and also understood the issue. This is a documentation change right? We need to change every instance of os.path.join() to Path(...).as_posix()?

Hey @Bhavay-2001 this is not a documentation change. Try going through this issue #6561 you'll understand why we are doing this.

[Bhavay-2001]

Hi @charchit7, yes I understood that this is to provide windows support for the adapter.py. I previously thought that it was a documentation change issue, however I have changed the file and opened the corresponding PR.
Thanks

[gzguevara]

Hi, @sayakpaul! Does this issue request to change all os.path.join() instances in the whole Diffusers repo? Can I just take any script containing os.path.join() and change it?

[sayakpaul]

I think so.

[gzguevara]

@sayakpaul there are quite a few such instances in training examples. I will tackle a few. ok?

[sayakpaul]

I think those are fine to leave as is because most of the training doesn't take place on Windows.

[stephen-iezzi]

@sayakpaul I searched across the entire diffusers repo and 111 files contain instance(s) of os.path.join however as you previously mentioned a lot of that is related to training. I then did a targeted search within diffusers/src/diffusers and this revealed a much smaller subset that contains 11 files and ~55 instances of os.path.join. One of these 11 files was addressed by Bhavay in this PR. Would it be worth me going after the other 10 files, most of which are within diffusers/src/diffusers/utils and diffusers/src/diffusers/pipelines?

[sayakpaul]

Yeah that works for me.

[Bhavay-2001]

Hi @sayakpaul, could you please review my PR.
Thanks

[sayakpaul]

Where is it?

[Bhavay-2001]

Please find the PR here

[Bhavay-2001]

Also, @Stepheni12 if you don't mind can we distribute the following tasks?

[stephen-iezzi]

Yes, @Bhavay-2001 that sounds good! There were 11 files in total and your PR already did one of them so we can just split the other 10 from this subset. You can take the top 5 files which are:

src/diffusers/utils/hub_utils.py
src/diffusers/utils/constants.py
src/diffusers/models/modeling_flax_utils.py
src/diffusers/configuration_utils.py
src/diffusers/utils/dynamic_modules_utils.py

and then I'll take the bottom half of the list which are:

src/diffusers/pipelines/onnx_utils.py
src/diffusers/pipelines/pipeline_flax_utils.py
src/diffusers/models/modeling_utils.py
src/diffusers/utils/testing_utils.py
src/diffusers/pipelines/pipeline_utils.py

[Bhavay-2001]

Sure @Stepheni12, I will update the mentioned files

[Bhavay-2001]

Hi @sayakpaul , @yiyixuxu it would be great if you guys could review the PRs associated with the issue and merge it or let us know of any changes to be made. Thanks

[Bhavay-2001]

The PRs are mentioned here. @sayakpaul