Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path to posix (modeling_utils.py) #6781

Merged

Conversation

stephen-iezzi
Copy link
Contributor

What does this PR do?

Introduces Posix to provide stronger support for Windows compatibility. Changes the instance of os.path.join() to Path(...).as_posix().

Fixes #6585

Before submitting

Who can review?

@sayakpaul

@sayakpaul sayakpaul requested a review from yiyixuxu January 31, 2024 07:42
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stephen-iezzi
Copy link
Contributor Author

Fixed formatting to pass quality checks

Copy link

github-actions bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 8, 2024
@yiyixuxu yiyixuxu removed the stale Issues that haven't received updates label Mar 8, 2024
@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Mar 8, 2024

hey can you fix the quality test?

@stephen-iezzi
Copy link
Contributor Author

Ran the style and quality checks!

@yiyixuxu yiyixuxu merged commit 161c6e1 into huggingface:main Mar 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracker] change to posix for better Windows support
4 participants