Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the watchdog option and integration #2513

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

kevinrenskers
Copy link
Contributor

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rename the integration.

@github-actions
Copy link

github-actions bot commented Dec 12, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.20 ms 1265.28 ms 34.08 ms
Size 20.75 KiB 405.16 KiB 384.41 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
3fdb749 1227.42 ms 1248.48 ms 21.06 ms
bd284cf 1237.24 ms 1261.33 ms 24.08 ms
bbe81cb 1257.25 ms 1272.24 ms 14.99 ms
bd284cf 1241.12 ms 1249.22 ms 8.10 ms
f8045b6 1206.76 ms 1233.41 ms 26.65 ms
91350d7 1230.82 ms 1253.26 ms 22.44 ms
6ef7dc2 1204.14 ms 1253.76 ms 49.62 ms
a745091 1230.76 ms 1246.40 ms 15.64 ms
1bf9e40 1267.37 ms 1268.80 ms 1.43 ms
8361c4c 1204.07 ms 1252.74 ms 48.67 ms

App size

Revision Plain With Sentry Diff
3fdb749 20.75 KiB 383.81 KiB 363.06 KiB
bd284cf 20.75 KiB 405.06 KiB 384.31 KiB
bbe81cb 20.75 KiB 381.81 KiB 361.06 KiB
bd284cf 20.75 KiB 405.06 KiB 384.31 KiB
f8045b6 20.75 KiB 404.83 KiB 384.08 KiB
91350d7 20.75 KiB 383.89 KiB 363.14 KiB
6ef7dc2 20.75 KiB 383.39 KiB 362.64 KiB
a745091 20.75 KiB 383.89 KiB 363.14 KiB
1bf9e40 20.75 KiB 405.06 KiB 384.31 KiB
8361c4c 20.75 KiB 383.87 KiB 363.12 KiB

Previous results on branch: ref/rename-watchdog-option

Startup times

Revision Plain With Sentry Diff
1f38005 1199.33 ms 1229.63 ms 30.31 ms

App size

Revision Plain With Sentry Diff
1f38005 20.75 KiB 405.16 KiB 384.41 KiB

@kevinrenskers kevinrenskers changed the title Rename the watchdog option Rename the watchdog option and integration Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2513 (92b7ed2) into 8.0.0 (6c7ab81) will increase coverage by 0.10%.
The diff coverage is 66.66%.

❗ Current head 92b7ed2 differs from pull request most recent head 3458c6a. Consider uploading reports for the commit 3458c6a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2513      +/-   ##
==========================================
+ Coverage   78.44%   78.54%   +0.10%     
==========================================
  Files         242      241       -1     
  Lines       22276    22289      +13     
  Branches     9834     9847      +13     
==========================================
+ Hits        17475    17508      +33     
+ Misses       4350     4331      -19     
+ Partials      451      450       -1     
Impacted Files Coverage Δ
Sources/Sentry/SentryBaseIntegration.m 90.90% <33.33%> (ø)
Sources/Sentry/SentryOptions.m 87.20% <100.00%> (ø)
Sources/Sentry/SentryWatchdogTerminationsLogic.m 62.26% <100.00%> (ø)
...ry/SentryWatchdogTerminationsTrackingIntegration.m 86.36% <100.00%> (ø)
Sources/Sentry/SentryRequestOperation.m 67.56% <0.00%> (-10.82%) ⬇️
Sources/Sentry/SentryNetworkTracker.m 94.48% <0.00%> (-0.73%) ⬇️
Sources/Sentry/include/SentryHexAddressFormatter.h
Sources/Sentry/SentryFileManager.m 96.00% <0.00%> (+0.42%) ⬆️
Sources/Sentry/SentryBacktrace.cpp 88.39% <0.00%> (+1.78%) ⬆️
Sources/Sentry/SentryMachLogging.cpp 2.51% <0.00%> (+2.51%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7ab81...3458c6a. Read the comment docs.

@kevinrenskers kevinrenskers merged commit 838ad6b into 8.0.0 Dec 12, 2022
@kevinrenskers kevinrenskers deleted the ref/rename-watchdog-option branch December 12, 2022 14:43
kevinrenskers added a commit that referenced this pull request Dec 16, 2022
* 8.0.0: (31 commits)
  tests: Reenable testAddAndRemoveData (#2533)
  feat: support SENTRY_DSN environment var on macOS (#2534)
  Remove duplicate entry (#2532)
  fix: ARC issue for FileManager (#2525)
  feat: Add SwiftUI performance tracking (#2271)
  fix: Remove all permission checks (#2529)
  Remove the automatic `viewAppearing` span (#2511)
  Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526)
  fix: Don't add out of date context for crashes (#2523)
  ref: Rename isOOM to watchdog in Client (#2520)
  test: Fix disabled failing watchdog test (#2521)
  build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516)
  Rename the watchdog option and integration (#2513)
  feat: Enable CaptureFailedRequests by default (#2507)
  test: Fix asserts for SentryCrashTestInstallation (#2500)
  meta: User interaction tracing enabled per default (#2506)
  ref: Rename OOM to Watchdog Terminations (#2499)
  feat: enableUserInteractionTracing is GA (#2503)
  build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505)
  perf: Don't attach headers for SentryNoOpSpan (#2498)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants