Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enableUserInteractionTracing is GA #2503

Merged
merged 4 commits into from
Dec 9, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Dec 7, 2022

📜 Description

Remove the EXPERIMENTAL comment.

💡 Motivation and Context

Part of #2298.

💚 How did you test it?

No tests needed. Just removing a comment.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Remove the EXPERIMENTAL comment
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- enableUserInteractionTracing is GA ([#2503](https://github.com/getsentry/sentry-cocoa/pull/2503))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 09f3c40

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.16 ms 1255.96 ms 12.80 ms
Size 20.75 KiB 405.07 KiB 384.31 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
4a67681 1236.57 ms 1252.80 ms 16.23 ms
1bf9e40 1267.37 ms 1268.80 ms 1.43 ms
58ec104 1244.29 ms 1269.67 ms 25.39 ms
9f8d429 1239.57 ms 1255.12 ms 15.55 ms
3fdb749 1227.42 ms 1248.48 ms 21.06 ms
4a67681 1223.90 ms 1252.63 ms 28.73 ms
bbf5334 1216.84 ms 1238.82 ms 21.98 ms
2b42e4e 1212.52 ms 1249.24 ms 36.72 ms
8361c4c 1204.07 ms 1252.74 ms 48.67 ms
2bdea22 1204.84 ms 1229.92 ms 25.08 ms

App size

Revision Plain With Sentry Diff
4a67681 20.75 KiB 405.06 KiB 384.31 KiB
1bf9e40 20.75 KiB 405.06 KiB 384.31 KiB
58ec104 20.75 KiB 379.11 KiB 358.36 KiB
9f8d429 20.75 KiB 383.40 KiB 362.65 KiB
3fdb749 20.75 KiB 383.81 KiB 363.06 KiB
4a67681 20.75 KiB 405.07 KiB 384.31 KiB
bbf5334 20.75 KiB 383.37 KiB 362.62 KiB
2b42e4e 20.75 KiB 383.89 KiB 363.14 KiB
8361c4c 20.75 KiB 383.87 KiB 363.12 KiB
2bdea22 20.75 KiB 405.06 KiB 384.31 KiB

Previous results on branch: feat/enableUserInteractionTracing-GA

Startup times

Revision Plain With Sentry Diff
52050df 1211.08 ms 1232.16 ms 21.08 ms

App size

Revision Plain With Sentry Diff
52050df 20.75 KiB 404.83 KiB 384.08 KiB

@kevinrenskers
Copy link
Contributor Author

Docs PR: getsentry/sentry-docs#5919

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #2503 (af6ab83) into 8.0.0 (f8045b6) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2503      +/-   ##
==========================================
- Coverage   78.46%   78.43%   -0.03%     
==========================================
  Files         242      241       -1     
  Lines       22273    22275       +2     
  Branches     9829     9832       +3     
==========================================
- Hits        17476    17471       -5     
- Misses       4347     4353       +6     
- Partials      450      451       +1     
Impacted Files Coverage Δ
Sources/Sentry/NSDictionary+SentrySanitize.m 96.00% <0.00%> (-4.00%) ⬇️
Sources/SentryCrash/Recording/Tools/SentryHook.c 80.88% <0.00%> (-2.95%) ⬇️
Sources/Sentry/SentryFileManager.m 95.58% <0.00%> (-0.43%) ⬇️
Sources/Sentry/include/SentryHexAddressFormatter.h
Sources/Sentry/SentryNetworkTracker.m 95.28% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8045b6...af6ab83. Read the comment docs.

* 8.0.0:
  build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505)
  perf: Don't attach headers for SentryNoOpSpan (#2498)
  feat: Add synthetic for mechanism (#2501)
@kevinrenskers kevinrenskers merged commit bd284cf into 8.0.0 Dec 9, 2022
@kevinrenskers kevinrenskers deleted the feat/enableUserInteractionTracing-GA branch December 9, 2022 08:52
kevinrenskers added a commit that referenced this pull request Dec 16, 2022
* 8.0.0: (31 commits)
  tests: Reenable testAddAndRemoveData (#2533)
  feat: support SENTRY_DSN environment var on macOS (#2534)
  Remove duplicate entry (#2532)
  fix: ARC issue for FileManager (#2525)
  feat: Add SwiftUI performance tracking (#2271)
  fix: Remove all permission checks (#2529)
  Remove the automatic `viewAppearing` span (#2511)
  Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526)
  fix: Don't add out of date context for crashes (#2523)
  ref: Rename isOOM to watchdog in Client (#2520)
  test: Fix disabled failing watchdog test (#2521)
  build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516)
  Rename the watchdog option and integration (#2513)
  feat: Enable CaptureFailedRequests by default (#2507)
  test: Fix asserts for SentryCrashTestInstallation (#2500)
  meta: User interaction tracing enabled per default (#2506)
  ref: Rename OOM to Watchdog Terminations (#2499)
  feat: enableUserInteractionTracing is GA (#2503)
  build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505)
  perf: Don't attach headers for SentryNoOpSpan (#2498)
  ...
brustolin pushed a commit to getsentry/sentry-docs that referenced this pull request Jan 4, 2023
* fix(apple): Delete experimental note GA features

Remove experimental suffixes for user interaction tracing, which is now GA. See getsentry/sentry-cocoa#2503

* Remove the experimental note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants