Remove the automatic viewAppearing span

[kevinrenskers]

📜 Description

Deleting code 🎉

💡 Motivation and Context

Closes #2510

💚 How did you test it?

Removed the code and made unit tests pass.

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• Review from the native team if needed
• No breaking changes -> I guess technically speaking this is a breaking change

🔮 Next steps

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1195.96 ms	1232.94 ms	36.98 ms
Size	20.75 KiB	404.99 KiB	384.24 KiB

Baseline results on branch: 8.0.0

Startup times

Revision	Plain	With Sentry	Diff
bbe81cb	1257.25 ms	1272.24 ms	14.99 ms
909e73a	1217.78 ms	1229.70 ms	11.92 ms
a9e77dc	1231.94 ms	1254.85 ms	22.91 ms
a9db8a6	1199.83 ms	1234.56 ms	34.73 ms
6b8ec2a	1229.15 ms	1253.80 ms	24.65 ms
88ac2c2	1223.04 ms	1243.12 ms	20.08 ms
7f1b08e	1252.20 ms	1257.70 ms	5.50 ms
bc27163	1215.45 ms	1249.46 ms	34.01 ms
4dc66f6	1202.59 ms	1228.34 ms	25.75 ms
f8045b6	1226.25 ms	1252.41 ms	26.16 ms

App size

Revision	Plain	With Sentry	Diff
bbe81cb	20.75 KiB	381.81 KiB	361.06 KiB
909e73a	20.75 KiB	383.40 KiB	362.65 KiB
a9e77dc	20.75 KiB	379.12 KiB	358.36 KiB
a9db8a6	20.75 KiB	383.37 KiB	362.62 KiB
6b8ec2a	20.75 KiB	405.10 KiB	384.34 KiB
88ac2c2	20.75 KiB	373.61 KiB	352.86 KiB
7f1b08e	20.75 KiB	383.31 KiB	362.55 KiB
bc27163	20.75 KiB	405.10 KiB	384.34 KiB
4dc66f6	20.75 KiB	381.81 KiB	361.06 KiB
f8045b6	20.75 KiB	404.83 KiB	384.08 KiB

Previous results on branch: 2510/remove-viewAppearing

Startup times

Revision	Plain	With Sentry	Diff
712818b	1232.64 ms	1242.72 ms	10.08 ms
b58f4a9	1224.69 ms	1250.80 ms	26.11 ms
f172a25	1205.31 ms	1239.74 ms	34.43 ms

App size

Revision	Plain	With Sentry	Diff
712818b	20.75 KiB	405.01 KiB	384.25 KiB
b58f4a9	20.75 KiB	404.99 KiB	384.24 KiB
f172a25	20.75 KiB	405.01 KiB	384.26 KiB

[codecov]

Codecov Report

Merging #2511 (5663302) into 8.0.0 (0ccb7ce) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##            8.0.0    #2511      +/-   ##
==========================================
- Coverage   78.55%   78.42%   -0.14%     
==========================================
  Files         242      241       -1     
  Lines       22288    22273      -15     
  Branches     9844     9835       -9     
==========================================
- Hits        17508    17467      -41     
- Misses       4331     4353      +22     
- Partials      449      453       +4     

Impacted Files	Coverage Δ
.../Sentry/SentryUIViewControllerPerformanceTracker.m	98.55% <ø> (-0.10%)	⬇️
Sources/Sentry/SentryProfilingLogging.mm	0.00% <0.00%> (-51.86%)	⬇️
Sources/Sentry/include/SentryProfilingLogging.hpp	45.45% <0.00%> (-9.10%)	⬇️
Sources/Sentry/SentryTime.mm	57.89% <0.00%> (-5.27%)	⬇️
Sources/Sentry/SentryThreadMetadataCache.cpp	91.30% <0.00%> (-4.35%)	⬇️
Sources/Sentry/SentryThreadHandle.cpp	69.39% <0.00%> (-3.28%)	⬇️
Sources/Sentry/SentryThreadInspector.m	95.87% <0.00%> (-2.07%)	⬇️
Sources/Sentry/SentryNetworkTracker.m	95.28% <0.00%> (-0.11%)	⬇️
Sources/Sentry/SentryANRTracker.m	100.00% <0.00%> (ø)
Sources/Sentry/SentryBacktrace.cpp	88.39% <0.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ccb7ce...5663302. Read the comment docs.

[philipphofmann]

Thanks, it's always great to delete code 😀