test: Fix asserts for SentryCrashTestInstallation #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two asserts wrapped with SentryCrashCRASH_HAS_UIAPPLICATION were not executed. This is fixed now.
5 tasks
| @@ -62,7 +63,7 @@ - (void)testUninstall_CallsRemoveObservers | |||
| [installation uninstall]; | |||
|
|
|||
| #if SentryCrashCRASH_HAS_UIAPPLICATION | |||
| XCTAssertEqual(5, self.notificationCenter.removeObserverWithNameInvocations.count); | |||
| XCTAssertEqual(5, self.notificationCenter.removeObserverWithNameInvocationsCount); | |||
There was a problem hiding this comment.
m: I woud not add that new property and just keep using removeObserverWithNameInvocations.count.
There was a problem hiding this comment.
That doesn't work as Invocations is not public to ObjC.
| @@ -95,7 +96,7 @@ - (void)testUninstall_Install | |||
| crashHandlerDataAfterInstall:crashHandlerDataAfterInstall]; | |||
|
|
|||
| #if SentryCrashCRASH_HAS_UIAPPLICATION | |||
| XCTAssertEqual(55, self.notificationCenter.removeObserverWithNameInvocations.count); | |||
| XCTAssertEqual(55, self.notificationCenter.removeObserverWithNameInvocationsCount); | |||
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2500 +/- ##
==========================================
+ Coverage 78.38% 78.43% +0.05%
==========================================
Files 242 242
Lines 22273 22283 +10
Branches 9828 9832 +4
==========================================
+ Hits 17459 17478 +19
+ Misses 4361 4352 -9
Partials 453 453
Continue to review full report at Codecov.
|
armcknight
approved these changes
Dec 9, 2022
| @@ -1,8 +1,8 @@ | |||
| import Foundation | |||
|
|
|||
| @objc public class TestNSNotificationCenterWrapper: SentryNSNotificationCenterWrapper { | |||
| @objcMembers public class TestNSNotificationCenterWrapper: SentryNSNotificationCenterWrapper { | |||
kevinrenskers
added a commit
that referenced
this pull request
Dec 16, 2022
* 8.0.0: (31 commits) tests: Reenable testAddAndRemoveData (#2533) feat: support SENTRY_DSN environment var on macOS (#2534) Remove duplicate entry (#2532) fix: ARC issue for FileManager (#2525) feat: Add SwiftUI performance tracking (#2271) fix: Remove all permission checks (#2529) Remove the automatic `viewAppearing` span (#2511) Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526) fix: Don't add out of date context for crashes (#2523) ref: Rename isOOM to watchdog in Client (#2520) test: Fix disabled failing watchdog test (#2521) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516) Rename the watchdog option and integration (#2513) feat: Enable CaptureFailedRequests by default (#2507) test: Fix asserts for SentryCrashTestInstallation (#2500) meta: User interaction tracing enabled per default (#2506) ref: Rename OOM to Watchdog Terminations (#2499) feat: enableUserInteractionTracing is GA (#2503) build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505) perf: Don't attach headers for SentryNoOpSpan (#2498) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two asserts wrapped with SentryCrashCRASH_HAS_UIAPPLICATION were not executed. This is fixed now.
Came up in #2440 (comment)
#skip-changelog