4 ➡️ 5 #272
Merged
4 ➡️ 5 #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com> Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* base and entity features * Add base Cmake and plugin dummy feature * Replace dummy features with base ones * Added Simulation Features (#168) * added features * [Bullet] Bullet classic, Add sdf entities (#167) * Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model * Kinematics features (#169) * Kinematic Features * Free Group Features (#171) * [bullet] Basic Features (#172) * Fixed gravity, pose, and corrected some auto variables * [Bullet] Collision Features (#173) * Collision working * [bullet] Add find or construct link (#175) * Add Find or Construct Link function * Change function to return entity instead of identity * Remove loop creating links inside model * [Bullet] Mesh features (#178) * Collision working * [bullet] Joints implementation (#190) * Add placeholders joint features * Iteration to add joints after links * sdfConstructJoint math fixed * added missing dummys * added constraint to the world * Change dummy functions print to debug * fixed position * friction * fixed sdfLinkSearch * Joint velocity command * working version tunnels * added joint position methods * Add basic tests * Add missing override keyword * Updated CMake and replaced using with structs for feature lists * Save base when adding a mesh * deleted worlds Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Signed-off-by: Devansh <devansh@vt.edu>
Copied from #262. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* [Citadel] Update tutorials (#204) Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com> Signed-off-by: anindex <an.thai.le97@gmail.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org> * Remove tools/code_check and update codecov (#257) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix dart deprecation warning (#263) Copied from #262. Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Claire Wang <22240514+claireyywang@users.noreply.github.com> Co-authored-by: anindex <an.thai.le97@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Use [gs]etPrimarySlipCompliance with dart 6.10.0 These APIs are used in the upstream release of dartsim 6.10.0 and have been recently added to our fork, so start using them. * Improve slip compliance test coverage Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Use [gs]etPrimarySlipCompliance with dart 6.10.0 These APIs are used in the upstream release of dartsim 6.10.0 and have been recently added to our fork, so start using them. * Improve slip compliance test coverage Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 82.11% 75.62% -6.49%
==========================================
Files 111 127 +16
Lines 4528 5473 +945
==========================================
+ Hits 3718 4139 +421
- Misses 810 1334 +524
Continue to review full report at Codecov.
|
|
The segfault in the LinkFeaturesTest is the same as I was getting here: #261 I noticed that it seems to impact using sdformat from debs, but not from source on my system. |
…268) When a joint is created between BodyNodes in different skeletons, the child BodyNode is moved to the skeleton of the parent BodyNode. When this happens, the BodyNode version of the child needs to be incremented. This is actually fixed by dartsim/dart#1445, but we don't have that merged into our fork. So in the meantime, we call incrementVersion after moveTo is called similar to #31. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
I've looked into this test failure, and I believe there's a bug in the test itself. I'm adding a new API to libsdformat (see gazebosim/sdformat#601 and gazebosim/sdformat#602) to help detect when graphs are not properly loaded for a world, which should help with confirming the source of this bug |
Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
* Add Feature to Get/Set Gravity vector in a World * dartsim: implement Gravity Feature * Test Gravity APIs in WorldFeatures_TEST * FrameSemantics: improve handling of World frame Avoid calling FrameDataRelativeToWorld for quantities relative to the world frame but expressed in different coordinates. This prevents an assertion in KinematicsFeatures.cc * Fix LinkFeatures_TEST by using Gravity Feature * ShapeFeatures_TEST: remove unused LoadWorld function * Fix doxygen parameter name in World.hh Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
edcb1c8 to
6ccca59
Compare
scpeters
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-physics4tomainBranch comparison: main...ign-physics4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸