Free Group Feature #171
Merged
Free Group Feature #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com>
Codecov Report
@@ Coverage Diff @@
## bullet_classic_dev #171 +/- ##
======================================================
- Coverage 80.03% 79.55% -0.49%
======================================================
Files 112 113 +1
Lines 4123 4148 +25
======================================================
Hits 3300 3300
- Misses 823 848 +25
Continue to review full report at Codecov.
|
Blast545
approved these changes
Nov 25, 2020
| @@ -56,7 +56,8 @@ struct ModelInfo | |||
| { | |||
| std::string name; | |||
| Identity world; | |||
| std::vector<std::size_t> links = {}; | |||
| bool fixed; | |||
There was a problem hiding this comment.
If the models are entities on its own, shouldn't be a boolean like this be on top of the links instead? Can models be composed of fixed links + not fixed ones?
Blast545
pushed a commit
that referenced
this pull request
Feb 3, 2021
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com>
Blast545
pushed a commit
that referenced
this pull request
Feb 12, 2021
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com>
Blast545
pushed a commit
that referenced
this pull request
Feb 12, 2021
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Blast545
pushed a commit
that referenced
this pull request
Feb 18, 2021
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Lobotuerk
added a commit
that referenced
this pull request
May 19, 2021
Signed-off-by: Lobotuerk <jtlorente@ekumenlabs.com> Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Blast545
added a commit
that referenced
this pull request
May 20, 2021
* base and entity features * Add base Cmake and plugin dummy feature * Replace dummy features with base ones * Added Simulation Features (#168) * added features * [Bullet] Bullet classic, Add sdf entities (#167) * Add SDF features to build models * Fix class inheritance problem * Comment unused variables in this commit * Add vector with ids of links added in a model * Kinematics features (#169) * Kinematic Features * Free Group Features (#171) * [bullet] Basic Features (#172) * Fixed gravity, pose, and corrected some auto variables * [Bullet] Collision Features (#173) * Collision working * [bullet] Add find or construct link (#175) * Add Find or Construct Link function * Change function to return entity instead of identity * Remove loop creating links inside model * [Bullet] Mesh features (#178) * Collision working * [bullet] Joints implementation (#190) * Add placeholders joint features * Iteration to add joints after links * sdfConstructJoint math fixed * added missing dummys * added constraint to the world * Change dummy functions print to debug * fixed position * friction * fixed sdfLinkSearch * Joint velocity command * working version tunnels * added joint position methods * Add basic tests * Add missing override keyword * Updated CMake and replaced using with structs for feature lists * Save base when adding a mesh * deleted worlds Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com> Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lobotuerk jtlorente@ekumenlabs.com