Merge 6 -> 7 #316
Merged
Merge 6 -> 7 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gazebosim/gz-sim#1011 Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* share updated GUI ECM info with server on play Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * clarify docs and fix service request type Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * send event on play/pause/step Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * support service and event Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * fix tests Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * Flip the default settng of usEvent in order to maintain current behavior by default Signed-off-by: Nate Koenig <nate@openrobotics.org> * ignore stats msgs triggered by a step Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * explicit constructor for new gui event Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * remove deprecation notes (support both event and service) Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * test event behavior Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * add missing helper test class Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * Disable tests on windows Signed-off-by: Nate Koenig <nate@openrobotics.org> * Address PR feedback Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
|
needed by gazebosim/gz-sim#1183 |
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
+ Coverage 65.42% 65.74% +0.31%
==========================================
Files 32 34 +2
Lines 4686 4752 +66
==========================================
+ Hits 3066 3124 +58
- Misses 1620 1628 +8
Continue to review full report at Codecov.
|
jennuine
approved these changes
Nov 18, 2021
README.md
Outdated
Comment on lines
12
to
15
| Test coverage | [](https://codecov.io/gh/ignitionrobotics/ign-gui/branch/main) | ||
| Ubuntu Bionic | [](https://build.osrfoundation.org/job/ignition_gui-ci-main-bionic-amd64) | ||
| Homebrew | [](https://build.osrfoundation.org/job/ignition_gui-ci-main-homebrew-amd64) | ||
| Windows | [](https://build.osrfoundation.org/job/ign_gui-ci-win) | ||
| Test coverage | [](https://codecov.io/gh/ignitionrobotics/ign-gui/branch/ign-gui6) | ||
| Ubuntu Bionic | [](https://build.osrfoundation.org/job/ignition_gui-ci-ign-gui6-bionic-amd64) | ||
| Homebrew | [](https://build.osrfoundation.org/job/ignition_gui-ci-ign-gui6-homebrew-amd64) | ||
| Windows | [](https://build.osrfoundation.org/job/ign_gui-ign-6-win) |
There was a problem hiding this comment.
I think these changes need to be reverted
There was a problem hiding this comment.
fixed in a force-push amend: 41e1e52
|
some github actions test failures, but otherwise clean; I will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gui6tomainBranch comparison: main...ign-gui6
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)