Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 ➡️ 5 #304

Merged
merged 7 commits into from
Oct 13, 2021
Merged

4 ➡️ 5 #304

merged 7 commits into from
Oct 13, 2021

Conversation

jennuine
Copy link
Contributor

➡️ Forward port

Port ign-gui4 to ign-gui5

Branch comparison: ign-gui5...ign-gui4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

darksylinc and others added 7 commits September 20, 2021 09:56
Fixes gazebosim/gz-sim#1011

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine requested a review from chapulina as a code owner October 13, 2021 17:52
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #304 (a303da4) into ign-gui5 (1cad501) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head a303da4 differs from pull request most recent head 364fdda. Consider uploading reports for the commit 364fdda to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui5     #304      +/-   ##
============================================
- Coverage     66.12%   66.10%   -0.03%     
============================================
  Files            26       26              
  Lines          3218     3219       +1     
============================================
  Hits           2128     2128              
- Misses         1090     1091       +1     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 30.08% <0.00%> (-0.25%) ⬇️
include/ignition/gui/Plugin.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cad501...364fdda. Read the comment docs.

@chapulina chapulina merged commit fb00fb3 into ign-gui5 Oct 13, 2021
@chapulina chapulina deleted the jennuine/4_to_5 branch October 13, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants