Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ign-gazebo7 #1183

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Bumps in garden : ign-gazebo7 #1183

merged 5 commits into from
Nov 19, 2021

Conversation

scpeters
Copy link
Member

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI is green and comments have been addressed

@scpeters
Copy link
Member Author

I think we need to merge forward ign-gui

@scpeters
Copy link
Member Author

I think we need to merge forward ign-gui

gazebosim/gz-gui#316

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1183 (d086150) into main (46fa228) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files         274      274           
  Lines       22446    22446           
=======================================
  Hits        13890    13890           
  Misses       8556     8556           
Impacted Files Coverage Δ
src/Server.cc 86.14% <0.00%> (-0.61%) ⬇️
src/EntityComponentManager.cc 87.15% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46fa228...d086150. Read the comment docs.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

CI is all green except for windows and macOS

  • windows fails to build ignition-common4 on beefy Cannot open include file: 'glib.h'
C:\vcpkg\installed\x64-windows\include\gts.h(24,10):
 fatal error C1083: Cannot open include file: 'glib.h': No such file or directory (compiling source file C:\Jenkins\workspace\ign_gazebo-pr-win\ws\ign-common\graphics\src\GTSMeshUtils.cc) [C:\Jenkins\workspace\ign_gazebo-pr-win\ws\build\ignition-common4\graphics\src\ignition-common4-graphics.vcxproj]
  • macOS has 11 test failures, which seems higher than normal. I see a similar number in recent builds on ign-gazebo5 and ign-gazebo6. I've triggered new builds for those release branches to get more data.

In the meantime, I think this PR is not the source of these problems, so I will merge

@scpeters scpeters merged commit cddc011 into main Nov 19, 2021
@scpeters scpeters deleted the bump_garden_ign-gazebo7 branch November 19, 2021 17:46
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants