Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #311

Merged
merged 11 commits into from
Nov 5, 2021
Merged

5 ➡️ 6 #311

merged 11 commits into from
Nov 5, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui5 to ign-gui6

Branch comparison: ign-gui6...ign-gui5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

darksylinc and others added 10 commits September 20, 2021 09:56
Fixes gazebosim/gz-sim#1011

Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* 🎈5.3.0

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* removed entry

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine as a code owner November 5, 2021 03:27
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 5, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #311 (d790029) into ign-gui6 (a8e18ab) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui6     #311      +/-   ##
============================================
- Coverage     65.65%   65.63%   -0.02%     
============================================
  Files            32       32              
  Lines          4722     4723       +1     
============================================
  Hits           3100     3100              
- Misses         1622     1623       +1     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh 100.00% <ø> (ø)
src/plugins/image_display/ImageDisplay.cc 30.08% <0.00%> (-0.25%) ⬇️
include/ignition/gui/Plugin.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e18ab...d790029. Read the comment docs.

@chapulina chapulina merged commit ce4a07f into ign-gui6 Nov 5, 2021
@chapulina chapulina deleted the chapulina/5_to_6 branch November 5, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants