Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rc): Add Remote Config Management API #502

Merged
merged 14 commits into from
Dec 14, 2020
Merged

Conversation

lahirumaramba
Copy link
Member

RELEASE NOTES: Added support for the Remote Config API. This API enables Firebase developers to programmatically manage the set of JSON-formatted parameters and conditions known as the Remote Config template.

Resolves: #446

- Add initial classes for Remote Config API
- Add unit tests
* Add the entry point for Remote Config

* Remove the builder in RemoteConfig.java

* Remove fromApp and use the constructor directly

* Fix doc strings
- Introduce Response Types and Public Types
- Implement toResponseType() and toPublicType()
- Add parameters to RemoteConfigTemplate
- Add unit tests
* Refactor Public and Response types

* reformat code

* Clean up code style

* Remove getUseInAppDefault and use the value type in setter
* Add Remote Config conditions to template
* Introduce Parameter Groups

* Refactor unit tests

* PR fixes

* Fix variable names in unit tests
* Add Version information to RC template

* PR fixes

* PR fixes

* Clean up template unit tests
…ns (#496)

* Add Pubish, Validate, and GetTemplateAtVersion operations

* Clean up tests

* Move PublishOptions to parent package
* Add Remote Config rollback operation

* PR fixes
* Add List Versions operation in Remote Config

* PR fixes

* Move convertToUtcZuluFormat to utils class
* Add toJSON and fromJSON to Remote Config Template
* Add Remote Config Integration tests

* Updated listversions tests to use the sync apis
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lahiru! A few questions and things.

@lahirumaramba
Copy link
Member Author

Thank you, @egilmorez !
Made the changes and replied to the comments.

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Support For Remote Config in JAVA admin SDK
3 participants