Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Remote Config Parameter Group type #490

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Add Remote Config Parameter Group type #490

merged 4 commits into from
Nov 2, 2020

Conversation

lahirumaramba
Copy link
Member

  • Add Remote Config Parameter Group type
  • Implement equals() in all public RC types
  • Add unit tests for public RC types
  • Refactor existing unit tests to use equals() when comparing templates

Related to: #446

hiranya911
hiranya911 suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I only had a few nits.

src/main/java/com/google/firebase/remoteconfig/ParameterGroup.java Show resolved Hide resolved
src/main/java/com/google/firebase/remoteconfig/Template.java Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/ConditionTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/ParameterTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/TemplateTest.java Outdated Show resolved Hide resolved
hiranya911
hiranya911 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit: Unit tests use a lot of short variable names like c and p. That's not very Java idiomatic.

@lahirumaramba
Copy link
Member Author

LGTM

Nit: Unit tests use a lot of short variable names like c and p. That's not very Java idiomatic.

Thanks for pointing this out!! Updated with proper variable names!

@lahirumaramba lahirumaramba merged commit cd5dfda into remote-config Nov 2, 2020
@lahirumaramba lahirumaramba deleted the lm-rc-param-groups branch November 2, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahirumaramba @hiranya911