Add the entry point for Remote Config #478
Conversation
| private final FirebaseApp app; | ||
| private final Supplier<? extends FirebaseRemoteConfigClient> remoteConfigClient; | ||
|
|
||
| private FirebaseRemoteConfig(Builder builder) { |
There was a problem hiding this comment.
A builder is overkill for just 2 arguments. I'd recommend something simpler and direct:
@VisibleForTesting
FirebaseRemoteConfig(FirebaseApp app, FirebaseRemoteConfigClient client) {
this.app = checkNotNull(app);
this.client = checkNotNull(client);
}
private FirebaseRemoteConfig(FirebaseApp app) {
this(app, FirebaseRemoteConfigClientImpl.fromApp(app));
}Note that I'm also not using a Supplier here. Since the client is needed for all operations in this API, there's no reason to lazy initialize it.
There was a problem hiding this comment.
Good point! Updated the code.
I had to update the unit test for testRemoteConfigClientWithoutProjectId(). As the client is now initialized at construction it throws at FirebaseRemoteConfig.getInstance().
| import org.junit.Test; | ||
|
|
||
| public class FirebaseRemoteConfigTest { | ||
| private static final FirebaseOptions TEST_OPTIONS = FirebaseOptions.builder() |
|
@hiranya911 |
|
@egilmorez : Please review the docs in |
|
|
||
| static Builder builder() { | ||
| return new Builder(); | ||
| return new FirebaseRemoteConfig(app); |
There was a problem hiding this comment.
Remove fromApp. Call constructor directly where it's needed.
| /** | ||
| * This class is the entry point for all server-side Firebase Remote Config actions. | ||
| * | ||
| * <p>You can get an instance of FirebaseRemoteConfig via {@link #getInstance(FirebaseApp)}, and |
| /** | ||
| * Similar to {@link #getTemplate()} but performs the operation asynchronously. | ||
| * | ||
| * @return An {@code ApiFuture} that will complete with a {@link RemoteConfigTemplate} when |
There was a problem hiding this comment.
Suggest present tense, just "completes"
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
Show resolved
Hide resolved
6cf3a01 to
04906aa
Compare
FirebaseRemoteConfig.javagetTemplate()andgetTemplateAsync()Issue: #446
Note: Merging to
remote-configbranch.