Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add List Versions operation in Remote Config #498

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Add List Versions operation in Remote Config #498

merged 3 commits into from
Dec 2, 2020

Conversation

lahirumaramba
Copy link
Member

  • Add List Versions operation in Remote Config
  • Add ListVersionsOptions, ListVersionsResult types
  • Add unit tests

Related to #446

@lahirumaramba
Copy link
Member Author

lahirumaramba commented Dec 1, 2020 •
edited
Loading

Note: Still in draft. Needs to be rebased after #497

@lahirumaramba lahirumaramba force-pushed the lm-rc-rollback-listversions branch 2 times, most recently from 460d914 to 180f8f9 Compare December 1, 2020 23:12
@lahirumaramba lahirumaramba force-pushed the lm-rc-rollback-listversions branch from 180f8f9 to c965c48 Compare December 1, 2020 23:14
@lahirumaramba lahirumaramba marked this pull request as ready for review December 1, 2020 23:17
hiranya911
hiranya911 suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few thoughts on improving the implementation.

src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java Show resolved Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java Outdated Show resolved Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java Outdated Show resolved Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsResult.java Outdated Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImplTest.java Outdated Show resolved Hide resolved
src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java Outdated Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/ListVersionsResultTest.java Outdated Show resolved Hide resolved
hiranya911
hiranya911 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM with a suggestion.

src/main/java/com/google/firebase/remoteconfig/ListVersionsOptions.java Outdated
return this;
}

private String convertToUtcZuluFormat(long millis) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably belongs in the shared util. I assume there are other places where this is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Currently, we use it only in ListVersionsOptions. I moved it to Utils anyway to future proof :)

@lahirumaramba lahirumaramba merged commit 8085cee into remote-config Dec 2, 2020
@lahirumaramba lahirumaramba deleted the lm-rc-rollback-listversions branch December 2, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahirumaramba @hiranya911