Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add metadata root actions and error handling #1135

Merged
merged 2 commits into from
Jun 4, 2022

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 31, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

How

These methods are the methods that should be used in the commands, they combine everything from the metadata into simple routines.

Test Plan

If you go to PR #1083, you can test these actions directly from eas metadata and eas metadata:configure.

@byCedric byCedric force-pushed the @bycedric/metadata/actions branch from 19c7263 to f73ac8f Compare June 3, 2022 10:32
@byCedric byCedric marked this pull request as ready for review June 3, 2022 10:33
@byCedric byCedric requested a review from EvanBacon June 3, 2022 10:33
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

Size Change: +2.22 kB (0%)

Total Size: 25.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.1 MB +2.22 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1135 (f73ac8f) into main (4c6226b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   50.96%   50.96%           
=======================================
  Files         363      363           
  Lines       13026    13026           
  Branches     2670     2670           
=======================================
  Hits         6637     6637           
  Misses       5876     5876           
  Partials      513      513           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6226b...f73ac8f. Read the comment docs.

Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note or open a linear task to test these after app.js, otherwise code looks solid

@byCedric byCedric merged commit 940e3f6 into main Jun 4, 2022
@byCedric byCedric deleted the @bycedric/metadata/actions branch June 4, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants