[eas-cli] Add retroactive code review changes #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Size Change: -436 B (0%) Total Size: 25.1 MB
|
3 tasks
6 tasks
wkozyra95
reviewed
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## @bycedric/metadata/commands #1147 +/- ##
===============================================================
- Coverage 50.75% 50.74% -0.00%
===============================================================
Files 371 371
Lines 13230 13234 +4
Branches 2685 2687 +2
===============================================================
+ Hits 6713 6714 +1
- Misses 5997 6000 +3
Partials 520 520
Continue to review full report at Codecov.
|
9 tasks
3c13ee6 to
fb7021b
Compare
dsokal
reviewed
Jun 8, 2022
byCedric
added a commit
that referenced
this pull request
Jun 13, 2022
* [eas-cli] Add public access modifiers to classes * [eas-cli] Add specific types to date precision remover * [eas-cli] Add try catch around writing json to always unsubscribe * [eas-cli] Add async return await to uploadAsync log methods * [eas-cli] Fix date precision type and test * [eas-cli] Use submission profile bundle id if defined * [eas-cli] Drop catch from IO try catch block * [eas-cli] Move unique helper to global utils * [eas-cli] Prefer nullish coalescing
byCedric
added a commit
that referenced
this pull request
Jun 14, 2022
* [eas-cli] Add metadata commands * Add myself as codeowner to the metadata * [eas-cli] Hide the metadata commands for now * Add metadata changelog entry * [eas-cli] Update metadata configure command description * [eas-cli] Drop non-interactive due to limitations in AppStoreApi * [eas-cli] Reimplement credentials context for metadata * [eas-cli] Drop non-interactive flag in metadata command * [eas-cli] Drop args from metadata:configure Co-authored-by: Wojciech Kozyra <wojciech.kozyra@swmansion.com> * [eas-cli] Add retroactive code review changes (#1147) * [eas-cli] Add public access modifiers to classes * [eas-cli] Add specific types to date precision remover * [eas-cli] Add try catch around writing json to always unsubscribe * [eas-cli] Add async return await to uploadAsync log methods * [eas-cli] Fix date precision type and test * [eas-cli] Use submission profile bundle id if defined * [eas-cli] Drop catch from IO try catch block * [eas-cli] Move unique helper to global utils * [eas-cli] Prefer nullish coalescing * [eas-cli] Move metadata commands to pull and push * [eas-cli] Drop the platform option from the push command * [eas-cli] Remove alias and reword descriptions * [eas-cli] Auto-configure eas.json with metadata when missing (#1156) * [eas-cli] Polish the command output for release (#1159) * [eas-cli] Finalize metadata logging output * [eas-cli] Fix logging validation errors when store.config.json is not found * [eas-cli] Make all localized entites bold * [eas-cli] Make version string visible in logs * [eas-cli] Add note about early beta * [eas-cli] Remove hidden from meta commands * [eas-cli] Add metadata topic * [eas-cli] Rename eas metadata to eas metadata:push in logging * [eas-cli] Remove unused arg flag from push Co-authored-by: Wojciech Kozyra <wojciech.kozyra@swmansion.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]and CHANGELOG.md will be updated automatically.→ see PR [eas-cli] Add metadata commands #1136
Why
Retroactive PR review changes
How
See:
Test Plan
See CI and (e2e) tests.