Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add retroactive code review changes #1147

Merged
merged 9 commits into from
Jun 13, 2022
Merged

[eas-cli] Add retroactive code review changes #1147

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f4fa06
[eas-cli] Add public access modifiers to classes
byCedric Jun 7, 2022
052f40d
[eas-cli] Add specific types to date precision remover
byCedric Jun 7, 2022
a22074f
[eas-cli] Add try catch around writing json to always unsubscribe
byCedric Jun 7, 2022
38dd00c
[eas-cli] Add async return await to uploadAsync log methods
byCedric Jun 7, 2022
4b53623
[eas-cli] Fix date precision type and test
byCedric Jun 8, 2022
fb7021b
[eas-cli] Use submission profile bundle id if defined
byCedric Jun 8, 2022
8e2dc55
[eas-cli] Drop catch from IO try catch block
byCedric Jun 8, 2022
13c61fe
[eas-cli] Move unique helper to global utils
byCedric Jun 8, 2022
e486f17
[eas-cli] Prefer nullish coalescing
byCedric Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/eas-cli/src/metadata/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,13 @@ export async function downloadMetadataAsync(metadataCtx: MetadataContext): Promi
}
}

await fs.writeJson(filePath, config.toSchema(), { spaces: 2 });
unsubscribeTelemetry();
try {
await fs.writeJson(filePath, config.toSchema(), { spaces: 2 });
} catch (error) {
throw error;
} finally {
unsubscribeTelemetry();
}

if (errors.length > 0) {
throw new MetadataDownloadError(errors, executionId);
Expand Down