Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata] Add first draft of app store connect metadata sync #1083

Closed
wants to merge 5 commits into from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Apr 25, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

This PR has been split

In order to do proper review, I separated this PR into a set of other PRs.

Why

First draft of the EAS submit metadata, running everything locally.

Note, we might need to move this over to EAS submit service instead.

How

This adds basic App Store Connect metadata configuration syncs using a couple of concepts.

  1. config schema → JSON Schema that defines the available configuration options available. (Using JSON Schemas allows us to create autocomplete in editors like vscode)
  2. config reader → Deserializer object to convert the JSON data to ASC model attributes. (Could change per config schema version)
  3. context → A set of ASC model instances to communicate with the ASC API.
  4. sync tasks → A simple task runner system using preupload and upload stages, more info in the proposal.

Test Plan

For all apple metadata tasks, there are unit tests with mocked ASC responses.

The underlying HTTP library needs some patches for nock, the tests might fail until that's available.

@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Size Change: +370 kB (+1%)

Total Size: 25.8 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.8 MB +370 kB (+1%)

compressed-size-action

@byCedric byCedric force-pushed the @bycedric/metadata/draft branch from 692e0e7 to 0719abb Compare May 23, 2022 13:31
byCedric added 4 commits May 23, 2022 15:41
* [cli] Upgrade apple-utils with axios access

* [eas-cli] Fix schema not found by moving it outside source

* [eas-cli] Add metadata telemetry and error reporting

* [eas-cli] Add tests for telemetry data scrubber

* [eas-cli] Add metadata error documentation
* [eas-cli] Add config writer to serialize back to schema

* [eas-cli] Add config writer to pull data from ASC

* [eas-cli] Fix wrong entity used for categories

* [eas-cli] Clean up prepare tests without reader property

* [eas-cli] Add missing ora mocks

* [eas-cli] Move metadata to its own command

* [eas-cli] Finalize the initial draft of metadata
@byCedric
Copy link
Member Author

Closing, everything has been split and merged.

@byCedric byCedric closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants