[eas-cli] Update download and upload metadata methods to new ctx

expo · Jun 3, 2022 · 19c7263 · 19c7263
1 parent 3ee9d72
commit 19c7263
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/packages/eas-cli/src/metadata/download.ts b/packages/eas-cli/src/metadata/download.ts
@@ -14,30 +14,28 @@ import { subscribeTelemetry } from './utils/telemetry';
  * Generate a local store configuration from the stores.
  * Note, only App Store is supported at this time.
  */
-export async function downloadMetadataAsync(metadataContext: MetadataContext): Promise<string> {
-  const filePath = path.resolve(metadataContext.projectDir, metadataContext.metadataFile);
+export async function downloadMetadataAsync(metadataCtx: MetadataContext): Promise<string> {
+  const filePath = path.resolve(metadataCtx.projectDir, metadataCtx.metadataPath);
   const fileExists = await fs.pathExists(filePath);
 
-  if (fileExists && metadataContext.nonInteractive) {
-    throw new MetadataValidationError(`Store configuration already exists at "${filePath}"`);
-  } else if (fileExists) {
+  if (fileExists) {
     const overwrite = await confirmAsync({
-      message: `Do you want to overwrite the existing store configuration "${metadataContext.metadataFile}"?`,
+      message: `Do you want to overwrite the existing store configuration "${metadataCtx.metadataPath}"?`,
     });
     if (!overwrite) {
       throw new MetadataValidationError(`Store configuration already exists at "${filePath}"`);
     }
   }
 
-  const { app, auth } = await ensureMetadataAppStoreAuthenticatedAsync(metadataContext);
+  const { app, auth } = await ensureMetadataAppStoreAuthenticatedAsync(metadataCtx);
   const { unsubscribeTelemetry, executionId } = subscribeTelemetry(
     MetadataEvent.APPLE_METADATA_DOWNLOAD,
     { app, auth }
   );
 
   const errors: Error[] = [];
   const config = createAppleWriter();
-  const tasks = createAppleTasks(metadataContext);
+  const tasks = createAppleTasks(metadataCtx);
   const taskCtx = { app };
 
   for (const task of tasks) {

diff --git a/packages/eas-cli/src/metadata/upload.ts b/packages/eas-cli/src/metadata/upload.ts
@@ -13,13 +13,13 @@ import { subscribeTelemetry } from './utils/telemetry';
  * Sync a local store configuration with the stores.
  * Note, only App Store is supported at this time.
  */
-export async function uploadMetadataAsync(metadataContext: MetadataContext): Promise<void> {
-  const filePath = path.resolve(metadataContext.projectDir, metadataContext.metadataFile);
+export async function uploadMetadataAsync(metadataCtx: MetadataContext): Promise<void> {
+  const filePath = path.resolve(metadataCtx.projectDir, metadataCtx.metadataPath);
   if (!(await fs.pathExists(filePath))) {
     throw new MetadataValidationError(`Store configuration file not found "${filePath}"`);
   }
 
-  const { app, auth } = await ensureMetadataAppStoreAuthenticatedAsync(metadataContext);
+  const { app, auth } = await ensureMetadataAppStoreAuthenticatedAsync(metadataCtx);
   const { unsubscribeTelemetry, executionId } = subscribeTelemetry(
     MetadataEvent.APPLE_METADATA_UPLOAD,
     { app, auth }
@@ -33,7 +33,7 @@ export async function uploadMetadataAsync(metadataContext: MetadataContext): Pro
 
   const errors: Error[] = [];
   const config = createAppleReader(fileData);
-  const tasks = createAppleTasks(metadataContext);
+  const tasks = createAppleTasks(metadataCtx);
   const taskCtx = { app };
 
   for (const task of tasks) {