Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ctb): Upgrade foundry #8538

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix(ctb): Upgrade foundry #8538

merged 1 commit into from
Dec 11, 2023

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 8, 2023

Overview

Our current version of foundry had a bug in forge fmt. Upgrades foundry so that we don't go out of sync on lints.

@clabby
Copy link
Member Author

clabby commented Dec 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Dec 8, 2023
Merged
Merged
@clabby clabby self-assigned this Dec 8, 2023
@clabby clabby force-pushed the cl/ctb/upgrade-foundry branch from c295efa to 7f17f8e Compare December 9, 2023 00:02
@clabby clabby requested a review from a team as a code owner December 9, 2023 21:17
@clabby clabby requested review from refcell and removed request for a team December 9, 2023 21:17
@clabby clabby force-pushed the cl/ctb/upgrade-foundry branch from 7f17f8e to bdb55d0 Compare December 9, 2023 21:17
maurelian
maurelian approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging this to base branch with formatting changes to ensure CI doesn't break.

@maurelian maurelian merged commit c4b8351 into cl/ctb/test-lint Dec 11, 2023
@maurelian maurelian deleted the cl/ctb/upgrade-foundry branch December 11, 2023 13:55
clabby added a commit that referenced this pull request Dec 11, 2023
@clabby
Revert #8538
aa44367
@clabby clabby mentioned this pull request Dec 11, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2023
@mslipper
Merge pull request #8556 from ethereum-optimism/cl/revert-forge-upgrade
0d0c339 
Revert #8538
clabby added a commit that referenced this pull request Dec 12, 2023
@clabby
Revert #8538
376ef4f
@mds1 mds1 mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian approved these changes

@refcell refcell Awaiting requested review from refcell refcell was automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@clabby clabby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @maurelian