Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump forge to the 2023-12-14 nightly #8612

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Dec 14, 2023

Description

Context:

We now want to upgrade to the latest forge because our formal verification efforts with RV leverage forge cheats that were not finalized and working properly until a few days ago.

Additional context

I believe @tynes mentioned that when upgrading foundry we also need to trigger a release of ci-builder. Is there anything I need to do for that on this PR?

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #8612 (8f7057f) into develop (be83a27) will decrease coverage by 0.05%.
Report is 11 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8612      +/-   ##
===========================================
- Coverage    34.61%   34.57%   -0.05%     
===========================================
  Files          167      167              
  Lines         7162     7162              
  Branches      1212     1212              
===========================================
- Hits          2479     2476       -3     
- Misses        4532     4537       +5     
+ Partials       151      149       -2     
Flag Coverage Δ
cannon-go-tests 63.48% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 20.18% <ø> (-0.15%) ⬇️
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 42.18% <ø> (ø)
sdk-tests 42.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@mds1 mds1 marked this pull request as ready for review December 14, 2023 03:43
Copy link
Contributor

coderabbitai bot commented Dec 14, 2023

Walkthrough

Walkthrough

The provided text indicates a request for a summary of changes based on a .foundryrc file. However, there seems to be a misunderstanding as the text refers to a git commit hash change rather than a specific code difference. Without the actual unidiff snippet or more context, it's not possible to provide a detailed summary of the changes. The requestor is being asked to supply the actual code differences for a proper review.

Changes

File Summary of Changes
.foundryrc Misunderstanding noted; actual code diff requested for review.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@tynes
Copy link
Contributor

tynes commented Dec 14, 2023

I believe @tynes mentioned that when upgrading foundry we also need to trigger a release of ci-builder. Is there anything I need to do for that on this PR?

To do so, one must use github actions to trigger the release and then approve it to build/publish on circleci

@tynes tynes added this pull request to the merge queue Dec 14, 2023
Merged via the queue into develop with commit 2b4292d Dec 14, 2023
@tynes tynes deleted the build/bump-forge branch December 14, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants