-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ctb): OutputBisection
actor tests
#8536
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
73a438b
to
e017287
Compare
e017287
to
cebcb45
Compare
0dc7c4c
to
2a5bb07
Compare
e968477
to
8fef157
Compare
c295efa
to
7f17f8e
Compare
8fef157
to
e98088a
Compare
7f17f8e
to
bdb55d0
Compare
1433561
to
b09ddeb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #8536 +/- ##
===========================================
- Coverage 34.60% 25.68% -8.93%
===========================================
Files 167 119 -48
Lines 7155 4879 -2276
Branches 1209 1060 -149
===========================================
- Hits 2476 1253 -1223
+ Misses 4530 3523 -1007
+ Partials 149 103 -46
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a177b5d
to
f95003b
Compare
packages/contracts-bedrock/test/dispute/OutputBisectionGame.t.sol
Outdated
Show resolved
Hide resolved
f95003b
to
3dcfccb
Compare
WalkthroughWalkthroughThe changes involve updates to smart contracts related to dispute resolution, position tracking, and testing within a blockchain framework. A new version of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
4c45bc0
to
8e65880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Overview
Introduces a
GameSolver
harness for actor tests against theOutputBisectionGame
contract. Each actor is an abstractionaround the game solving logic, capable of participating in an
OutputBisectionGame
backed by theAlphabetVM2
.Test Cases
DEFENDER_WINS
DEFENDER_WINS
.CHALLENGER_WINS
.DEFENDER_WINS
CHALLENGER_WINS
DEFENDER_WINS
CHALLENGER_WINS
DEFENDER_WINS
CHALLENGER_WINS
l2Outputs
lengths (?)Metadata
closes https://github.com/ethereum-optimism/client-pod/issues/255
closes https://github.com/ethereum-optimism/client-pod/issues/253