Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ctb): fmt #8537

Merged
merged 4 commits into from
Dec 11, 2023
Merged

chore(ctb): fmt #8537

merged 4 commits into from
Dec 11, 2023

Conversation

clabby
Copy link
Member

@clabby clabby commented Dec 8, 2023

Overview

We're currently on an old version of forge with a bug in forge fmt. Formats the tests.

@clabby clabby requested a review from a team as a code owner December 8, 2023 23:53
@clabby clabby requested a review from maurelian December 8, 2023 23:53
Copy link
Contributor

coderabbitai bot commented Dec 8, 2023

Walkthrough

The changes across various Solidity smart contracts are primarily cosmetic, focusing on code formatting and readability improvements. They involve condensing multi-line statements into single lines, adjusting spacing, and reformatting object instantiations and constructor calls. These alterations do not impact the logic or functionality of the contracts but enhance clarity and maintainability.

Changes

File(s) Change Summary
.../test/L1/L2OutputOracle.t.sol
.../test/L2/SequencerFeeVault.t.sol
.../test/Safe/LivenessModule.t.sol
.../test/dispute/FaultDisputeGame.t.sol
.../test/dispute/OutputBisectionGame.t.sol
.../test/periphery/faucet/Faucet.t.sol
.../test/periphery/op-nft/Optimist.t.sol
.../test/periphery/op-nft/OptimistAllowlist.t.sol
.../test/universal/OptimismMintableERC721.t.sol
.../test/universal/StandardBridge.t.sol
Refactoring of instantiation and initialization of objects and variables into single-line statements for improved readability.
.../scripts/Deploy.s.sol
.../scripts/DeployPeriphery.s.sol
Reformatting of object instantiations and assignments, specifically by removing line breaks and adjusting the syntax.
.../src/universal/OptimismMintableERC20Factory.sol
.../src/universal/OptimismMintableERC721Factory.sol
Addition of spaces around the salt: salt parameter in contract instantiations, potentially for clarity.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@clabby
Copy link
Member Author

clabby commented Dec 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@clabby clabby mentioned this pull request Dec 8, 2023
11 tasks
@clabby clabby changed the title chore(ctb): fmt tests chore(ctb): fmt Dec 8, 2023
@clabby clabby mentioned this pull request Dec 8, 2023
@clabby clabby self-assigned this Dec 8, 2023
@maurelian
Copy link
Contributor

Why is it that tests are only affected?

@maurelian maurelian enabled auto-merge December 11, 2023 13:58
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #8537 (c4b8351) into develop (0a7104c) will decrease coverage by 0.05%.
Report is 26 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8537      +/-   ##
===========================================
- Coverage    34.64%   34.60%   -0.05%     
===========================================
  Files          167      167              
  Lines         7155     7155              
  Branches      1209     1209              
===========================================
- Hits          2479     2476       -3     
- Misses        4525     4530       +5     
+ Partials       151      149       -2     
Flag Coverage Δ
cannon-go-tests 63.48% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 20.24% <0.00%> (-0.15%) ⬇️
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 42.18% <ø> (ø)
sdk-tests 42.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ock/src/universal/OptimismMintableERC20Factory.sol 0.00% <0.00%> (ø)
...ck/src/universal/OptimismMintableERC721Factory.sol 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@maurelian maurelian added this pull request to the merge queue Dec 11, 2023
Merged via the queue into develop with commit 22f6efe Dec 11, 2023
@maurelian maurelian deleted the cl/ctb/test-lint branch December 11, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants