Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLab 3.0 RC #1063

Merged
merged 43 commits into from
Nov 23, 2020
Merged

Update to JupyterLab 3.0 RC #1063

merged 43 commits into from
Nov 23, 2020

Conversation

ajbozarth
Copy link
Member

@ajbozarth ajbozarth commented Nov 12, 2020

Update Elyra to run on JupyterLab 3.0 RC

The following temporary changes will need to be reverted prior to the next release:

  • adding --pre to applicable pip installs
  • commenting out dependancies and installations of the git extension

Fixes #832

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ajbozarth ajbozarth self-assigned this Nov 12, 2020
@ajbozarth ajbozarth requested a review from lresende November 12, 2020 02:08
@elyra-bot
Copy link

elyra-bot bot commented Nov 12, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ajbozarth
Copy link
Member Author

As I was opening this I noticed flake8 was commented out in the Makefile. I'm currently checking if that needs to be addressed and will push an update if it works as is, otherwise fixing flake will be a followup issue

@jtpio
Copy link

jtpio commented Nov 13, 2020

Just curious: do you also plan to adopt the new distribution system in lab 3.0 to distribute each extension separately as Python packages?

Or bundle them all in the main elyra package similar to the current approach?

elyra/setup.py

Line 102 in 19a484f

setup_args["data_files"].append(('share/jupyter/lab/extensions', glob(npm_packages_path)))

@ajbozarth
Copy link
Member Author

do you also plan to adopt the new distribution system in lab 3.0

We plan to initially continue using npm for our extension packages, as seen in this PR, to release 3.0 support asap. Then in a future release we plan to update to the new federated extensions, we have not decided how soon that update will happen though.

setup.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLab 3.0 Release (umbrella issue)
6 participants