Skip to content

Commit

Permalink
remove elyra launcher to be reverted later
Browse files Browse the repository at this point in the history
the launcher is broken and needs to be fixed, removing it for now
to allow work on other features while I address it. once I've found
I will revert this commit
  • Loading branch information
ajbozarth committed Oct 26, 2020
1 parent a992854 commit c651179
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 25 deletions.
4 changes: 1 addition & 3 deletions packages/theme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@
},
"jupyterlab": {
"extension": true,
"disabledExtensions": [
"@jupyterlab/launcher-extension"
]
"disabledExtensions": []
},
"publishConfig": {
"access": "public"
Expand Down
44 changes: 22 additions & 22 deletions packages/theme/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ import {
JupyterFrontEnd,
JupyterFrontEndPlugin
} from '@jupyterlab/application';
import { ICommandPalette, MainAreaWidget } from '@jupyterlab/apputils';
import { ILauncher, LauncherModel } from '@jupyterlab/launcher';
import { ICommandPalette /*, MainAreaWidget */ } from '@jupyterlab/apputils';
import { /*ILauncher,*/ LauncherModel } from '@jupyterlab/launcher';
import { IMainMenu } from '@jupyterlab/mainmenu';
import { launcherIcon } from '@jupyterlab/ui-components';
// import { launcherIcon } from '@jupyterlab/ui-components';

import { toArray } from '@lumino/algorithm';
import { Widget } from '@lumino/widgets';
// import { toArray } from '@lumino/algorithm';
// import { Widget } from '@lumino/widgets';

import { Launcher } from './launcher';
// import { Launcher } from './launcher';
import '../style/index.css';

const ELYRA_THEME_NAMESPACE = 'elyra-theme-extension';
Expand All @@ -44,18 +44,18 @@ const CommandIDs = {
/**
* Initialization data for the theme extension.
*/
const extension: JupyterFrontEndPlugin<ILauncher> = {
const extension: JupyterFrontEndPlugin<void> = {
id: ELYRA_THEME_NAMESPACE,
autoStart: true,
requires: [ILabShell, IMainMenu],
optional: [ICommandPalette],
provides: ILauncher,
// provides: ILauncher,
activate: (
app: JupyterFrontEnd,
labShell: ILabShell,
mainMenu: IMainMenu,
palette: ICommandPalette | null
): ILauncher => {
): void => {
console.log('Elyra - theme extension is activated!');

// Find the MainLogo widget in the shell and replace it with the Elyra Logo
Expand All @@ -80,7 +80,7 @@ const extension: JupyterFrontEndPlugin<ILauncher> = {
// Use custom Elyra launcher
const { commands } = app;
const model = new LauncherModel();

/*
commands.addCommand(CommandIDs.create, {
label: 'New Launcher',
execute: (args: any) => {
Expand Down Expand Up @@ -112,10 +112,10 @@ const extension: JupyterFrontEndPlugin<ILauncher> = {
return main;
}
});

if (palette) {
palette.addItem({ command: CommandIDs.create, category: 'Launcher' });
}
*/
// if (palette) {
// palette.addItem({ command: CommandIDs.create, category: 'Launcher' });
// }

commands.addCommand(CommandIDs.openHelp, {
label: 'Documentation',
Expand All @@ -131,19 +131,19 @@ const extension: JupyterFrontEndPlugin<ILauncher> = {
rank: 10
});

return model;
// return model;
}
};

/**
* The namespace for module private data.
*/
namespace Private {
/**
* The incrementing id used for launcher widgets.
*/
// eslint-disable-next-line
export let id = 0;
}
// namespace Private {
// /**
// * The incrementing id used for launcher widgets.
// */
// // eslint-disable-next-line
// export let id = 0;
// }

export default extension;

0 comments on commit c651179

Please sign in to comment.