Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterLab 3.0 Release (umbrella issue) #832

Closed
12 tasks done
kevin-bates opened this issue Aug 6, 2020 · 6 comments · Fixed by #1063
Closed
12 tasks done

JupyterLab 3.0 Release (umbrella issue) #832

kevin-bates opened this issue Aug 6, 2020 · 6 comments · Fixed by #1063

Comments

@kevin-bates
Copy link
Member

kevin-bates commented Aug 6, 2020

JupyterLab's 3.0 release will be based on Jupyter Server - rather than Notebook - among other things. This issue is created to track issues related to that effort.

Back-end tasks:

Front-end tasks:

  • Clean up build
    • Remove redundant build steps
    • Figure out if new build files can be created dynamically on build (look into how core does it)
  • Get theme extension working
  • Get pipeline extension working
  • Test functionality that appears to be working
  • Lab icon redundant import issue has returned

Issues found during integration:

@kevin-bates kevin-bates added this to the 2.0.0 milestone Aug 6, 2020
@kevin-bates kevin-bates added external:Upstream Depended on deliverables in other repos outside the elyra org external:jupyterlab 3.0 roadmap and removed external:Upstream Depended on deliverables in other repos outside the elyra org labels Aug 6, 2020
@ajbozarth
Copy link
Member

Copying my notes from scrum here for reference:

Worked on switching to Lab 3.0 alpha 14 (beta wasn't fully published yet) and ran into issues with the move to the federated build system. This Issue looks like it will be creating transition scripts for our build files, but as far as I tried, it's not yet working. It is probably worth waiting until there is more documentation around the new build system before spending more dev hours on transitioning to it.

@ajbozarth
Copy link
Member

ajbozarth commented Oct 21, 2020

3.0 changelog for reference: https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html

Task that need to be handled:

  • Clean up build
    • Remove redundant build steps
    • Figure out if new build files can be created dynamically on build (look into how core does it)
  • Get them extension working
  • Get pipeline extension working
  • Test functionality that appears to be working
  • lab icon redundant import issue has returned

Non-blocking upgrades to consider:

  • Support translation
  • Add debugger support to python editor
  • Support single document mode?

@ajbozarth
Copy link
Member

In an attempt to minimize the build changes I tried switching back to not using federated build, but hit a error, I've opened the following issue on lab to find a solution jupyterlab/jupyterlab#9203
If this can be solved it would address the Clean up build bullet.

@lresende lresende changed the title JupyterLab 3.0 Release Umbrella Issue JupyterLab 3.0 Release (umbrella issue) Oct 26, 2020
@kevin-bates
Copy link
Member Author

I notice the default configuration directory is changing from jupyter_notebook_config.d to jupyter_server_config.d and referenced in other places. Do we need to consider some kind of upgrade script or instructions? Might there also be pipeline updates for the 2.0 efforts?

@lresende
Copy link
Member

I believe this is already handled on #1063

auto_extension_path = "./etc/config/jupyter_notebook_config.d/*.json"
auto_extension_path = "./etc/config/jupyter_server_config.d/elyra.json" # TODO change back to include git

@kevin-bates
Copy link
Member Author

I guess I was assuming that users may have added information to their elyra.json file or even marked the elyra extension as disabled for the moment. Our objects do have configurable traits where this kind of thing would be configured (I think). Are we doing anything to preserve configuration settings when an existing user upgrades from elyra 1.x to elyra 2.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants