Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert server handler tests to Jupyter Server's framework #831

Closed
kevin-bates opened this issue Aug 6, 2020 · 1 comment
Closed

Convert server handler tests to Jupyter Server's framework #831

kevin-bates opened this issue Aug 6, 2020 · 1 comment
Labels
area:back-end component:test Test-related external:jupyterlab 3.0
Milestone
2.0.0

Comments

@kevin-bates
Copy link
Member

The server handler tests currently derive from Notebook's NotebookTestBase class. However, JupyterLab 3.0 will no longer use Notebook as its server and depend on Jupyter Server instead. At that time, we need to have our handler tests updated to use Jupyter Server's configurable_serverapp fixture.
@kevin-bates kevin-bates added this to the 2.0.0 milestone Aug 6, 2020
@kevin-bates kevin-bates mentioned this issue Aug 6, 2020
Closed
12 tasks
@kevin-bates
Copy link
Member Author

This issue should be resolved in the jupyterlab3 branch via commit 5a4c95f

@consideRatio consideRatio mentioned this issue Jul 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:back-end component:test Test-related external:jupyterlab 3.0
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@lresende @kevin-bates