Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jest tests #1020

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

marthacryan
Copy link
Member

@marthacryan marthacryan commented Oct 29, 2020

Fixes the jest test failures by updating the testutils version. Changes to using port 8890 by default for tests to avoid conflicts when JupyterLab is running.

Edit: no longer changes the port used by tests because of #1024

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that: 799189
   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Oct 29, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende
Copy link
Member

lresende commented Nov 1, 2020

Could we update this on master (on top of #1024).

@lresende lresende added this to the 1.4.0 milestone Nov 1, 2020
@marthacryan
Copy link
Member Author

@lresende Just tested locally on master and the newer version of testutils doesn't work with JupyterLab 2.2.9 due to server changes in 3.0, so I think we should keep this as a PR to the jupyterlab3 branch

@marthacryan
Copy link
Member Author

Also note: just removed the changes from the last two commits because they were duplicates of #1024 - this PR now only changes the version of the JupyterLab testutils.

@lresende lresende merged commit b059d11 into elyra-ai:jupyterlab3 Nov 4, 2020
@marthacryan marthacryan deleted the fix-application branch April 23, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants