Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fixes infinite loop when machine learning's create job API returns an error #42228

Merged
merged 1 commit into from
Jul 30, 2019
Merged

[SIEM] Fixes infinite loop when machine learning's create job API returns an error #42228

merged 1 commit into from
Jul 30, 2019

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Jul 30, 2019 •
edited
Loading

Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

Screen Shot 2019-07-29 at 11 22 39 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

- [ ] Documentation was added for features that require explanation or tutorials

- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

@FrankHassanabad FrankHassanabad self-assigned this Jul 30, 2019
@FrankHassanabad FrankHassanabad requested a review from spong July 30, 2019 05:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/secops

@FrankHassanabad FrankHassanabad changed the title [SIEM] Fixes infinite loop when machine learning create job returns an error [SIEM] Fixes infinite loop when machine learning's create job API returns an error Jul 30, 2019
spong
spong approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested against a cloud 7.3 instance and verified the fix is working. LGTM once green 👍

ml_infinite_loop_fix

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 3232530 into elastic:master Jul 30, 2019
@FrankHassanabad FrankHassanabad deleted the fix-infinite-loop branch July 30, 2019 19:55
@FrankHassanabad FrankHassanabad mentioned this pull request Jul 30, 2019
Merged
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Jul 30, 2019
@FrankHassanabad
Fix infinite loop (elastic#42228)
51aa314 
## Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

<img width="791" alt="Screen Shot 2019-07-29 at 11 22 39 PM" src="https://user-images.githubusercontent.com/1151048/62103608-293a5400-b25a-11e9-9a9d-a5af42f7e128.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
FrankHassanabad added a commit that referenced this pull request Jul 30, 2019
@FrankHassanabad
Fix infinite loop (#42228) (#42293)
9be59c0 
## Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

<img width="791" alt="Screen Shot 2019-07-29 at 11 22 39 PM" src="https://user-images.githubusercontent.com/1151048/62103608-293a5400-b25a-11e9-9a9d-a5af42f7e128.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 31, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/clone…
646afd9 
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (114 commits)
  [ML] Fixing empty index pattern list (elastic#42299)
  [Markdown] Shim new platform - cleanup plugin (elastic#41760)
  [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233)
  Add New Platform mocks for data plugin (elastic#42261)
  Http server route handler implementation (elastic#41894)
  [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534)
  [Code] distributed Code abstraction (elastic#41374)
  [SIEM] Sets page titles to the current page you are on  (elastic#42157)
  Saved Objects export API stable type order (elastic#42310)
  cancellation of interpreter execution (elastic#40238)
  [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198)
  Changed the job to work with a dedicated index (elastic#42297)
  FTR: fix testSubjects.missingOrFail (elastic#42290)
  Increase retry timeout to prevent flaky tests (elastic#42291)
  Spaces - make space a hidden saved object type (elastic#41688)
  Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300)
  Disable flaky log column reorder test (elastic#42285)
  Fixing add element in element reducer (elastic#42276)
  Fix infinite loop (elastic#42228)
  [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835)
  ...
spong pushed a commit to spong/kibana that referenced this pull request Aug 1, 2019
@FrankHassanabad @spong
Fix infinite loop (elastic#42228)
1bc7e30 
## Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

<img width="791" alt="Screen Shot 2019-07-29 at 11 22 39 PM" src="https://user-images.githubusercontent.com/1151048/62103608-293a5400-b25a-11e9-9a9d-a5af42f7e128.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@spong spong mentioned this pull request Aug 1, 2019
Merged
spong added a commit that referenced this pull request Aug 2, 2019
@spong
[7.3] [SIEM] Fixes infinite loop when machine learning's create job A…
3906833 
…PI returns an error (#42228) (#42466)

## Summary

Fixes infinite loop when machine learning create job returns an error

https://github.com/elastic/ingest-dev/issues/616

This now will show an error toaster pop up which acts as a circuit breaker and does not continuously hit the back end if you have create job errors such as this one:

<img width="791" alt="Screen Shot 2019-07-29 at 11 22 39 PM" src="https://user-images.githubusercontent.com/1151048/62103608-293a5400-b25a-11e9-9a9d-a5af42f7e128.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
release_note:fix Team:SIEM v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankHassanabad @elasticmachine @spong