[Markdown] Shim new platform - cleanup plugin #41760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
894d6f3 to
eefce12
Compare
💔 Build Failed |
💔 Build Failed |
54e8844 to
eefce12
Compare
💔 Build Failed |
💔 Build Failed |
41c649a to
cd79cfb
Compare
💔 Build Failed |
Merged
7 tasks
lukeelmers
reviewed
Jul 24, 2019
| import { LegacyPluginApi, LegacyPluginInitializer } from '../../../../src/legacy/types'; | ||
|
|
||
| const markdownPluginInitializer: LegacyPluginInitializer = ({ Plugin }: LegacyPluginApi) => | ||
| new Plugin({ | ||
| id: 'vis_type_markdown', |
There was a problem hiding this comment.
Per my note in this table vis PR, would you mind updating the id here and in package.json to revert to the previous markdown_vis? That way we can make these breaking changes at once.
|
Pinging @elastic/kibana-app-arch |
1285b04 to
f25fbde
Compare
alexwizp
commented
Jul 29, 2019
|
retest |
💚 Build Succeeded |
f25fbde to
49de30b
Compare
|
retest |
💚 Build Succeeded |
49de30b to
bbbb8ec
Compare
💚 Build Succeeded |
lukeelmers
approved these changes
Jul 30, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 31, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (114 commits) [ML] Fixing empty index pattern list (elastic#42299) [Markdown] Shim new platform - cleanup plugin (elastic#41760) [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233) Add New Platform mocks for data plugin (elastic#42261) Http server route handler implementation (elastic#41894) [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534) [Code] distributed Code abstraction (elastic#41374) [SIEM] Sets page titles to the current page you are on (elastic#42157) Saved Objects export API stable type order (elastic#42310) cancellation of interpreter execution (elastic#40238) [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198) Changed the job to work with a dedicated index (elastic#42297) FTR: fix testSubjects.missingOrFail (elastic#42290) Increase retry timeout to prevent flaky tests (elastic#42291) Spaces - make space a hidden saved object type (elastic#41688) Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300) Disable flaky log column reorder test (elastic#42285) Fixing add element in element reducer (elastic#42276) Fix infinite loop (elastic#42228) [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835) ...
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 31, 2019
* [Markdown] Shim new platform - cleanup plugin
alexwizp
added a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring of markdown plugin in accordance with the latest migration guide
What was done:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers