FTR: fix testSubjects.missingOrFail #42290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💚 Build Succeeded |
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 31, 2019
* [services/test_subject] fix missingOrFail * [services/test_subjects] allowHidden option for missingOrFail * [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 31, 2019
* [services/test_subject] fix missingOrFail * [services/test_subjects] allowHidden option for missingOrFail * [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Jul 31, 2019
* [services/test_subject] fix missingOrFail * [services/test_subjects] allowHidden option for missingOrFail * [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
dmlemeshko
added a commit
that referenced
this pull request
Jul 31, 2019
dmlemeshko
added a commit
that referenced
this pull request
Jul 31, 2019
dmlemeshko
added a commit
that referenced
this pull request
Jul 31, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 31, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (114 commits) [ML] Fixing empty index pattern list (elastic#42299) [Markdown] Shim new platform - cleanup plugin (elastic#41760) [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233) Add New Platform mocks for data plugin (elastic#42261) Http server route handler implementation (elastic#41894) [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534) [Code] distributed Code abstraction (elastic#41374) [SIEM] Sets page titles to the current page you are on (elastic#42157) Saved Objects export API stable type order (elastic#42310) cancellation of interpreter execution (elastic#40238) [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198) Changed the job to work with a dedicated index (elastic#42297) FTR: fix testSubjects.missingOrFail (elastic#42290) Increase retry timeout to prevent flaky tests (elastic#42291) Spaces - make space a hidden saved object type (elastic#41688) Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300) Disable flaky log column reorder test (elastic#42285) Fixing add element in element reducer (elastic#42276) Fix infinite loop (elastic#42228) [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42226
There is an issue with
testSubjects.missingOrFailfunction usingtestSubjects.existslogic:existsreturns the result as soon as the element is found & ignoring timeout formissingOrFailIt means that
missingOrFail('#my_id', 1000)ormissingOrFail('#my_id', 20000)will both fail if element still be present right when function is called (1st second)It was working fine for the case when element immediately goes away from DOM, but won't work if it sits in DOM for a while and then be gone.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers